GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40358: add strict parameter to pathlib.PurePath.relative_to by domragusa · Pull Request #19807 · python/cpython

Conversation

@domragusa

@domragusa domragusa commented Apr 30, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40358

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
domragusa added 3 commits April 30, 2020 00:17
@domragusa
add tests for pathlib.PurePath.relative_to(strict=False)
b3daa47
@domragusa
add strict option for pathlib.PurePath.relative_to
9892f8b
@domragusa
documentation for PurePath.relative_to strict parameter
3c10a8c
@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 30, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@domragusa

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Apr 30, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 30, 2020
@domragusa
add missing news entry
f1fb0a2
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Apr 30, 2020
@domragusa

domragusa commented Apr 30, 2020

Copy link
Copy Markdown
Contributor Author

see: #19813
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@domragusa domragusa closed this Apr 30, 2020
@domragusa
domragusa deleted the relative_to_not_strict branch May 28, 2020 17:00
@domragusa domragusa mannequin mentioned this pull request Jun 21, 2022
pathlib's relative_to should behave like os.path.relpath #84538
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@domragusa @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.