GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — [3.8] bpo-39562: Prevent collision of future and compiler flags (GH-19230) by pablogsal · Pull Request #19835 · python/cpython Conversation
|
|
We need to still maybe add a better way to document this? @vstinner Where would you like for the documentation for this change to live? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Can you at least backport the NEWS entry? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you add the NEWS entry.
I tested manually: this change does fix https://bugs.python.org/issue39562#msg365311
Sorry, something went wrong.
There was an error while loading. Please reload this page.
One option is to add a "Notable changes in Python 3.8.3" section since the change is backward incompatible. Something like: But it's up to you to decide if it's worth it or not. The 3.9 change is documented in What's New in Python 3.9, in the "Porting to Python 3.9" section: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh, seems like @isidentical used the new I will update the PR soon to solve this and with @vstinner suggestions |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…onGH-19230) The constant values of future flags in the __future__ module is updated in order to prevent collision with compiler flags. Previously PyCF_ALLOW_TOP_LEVEL_AWAIT was clashing with CO_FUTURE_DIVISION.. (cherry picked from commit 4454057) Co-authored-by: Batuhan Taşkaya <[email protected]>
8112c50 to
5131901
Compare
|
@pablogsal: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.