GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40465: Deprecate the optional argument to random.shuffle(). by rhettinger · Pull Request #19867 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented May 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40465

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
bpo-40465: Deprecate the optional argument to random.shuffle().
42ce9b2
@rhettinger
rhettinger requested a review from serhiy-storchaka May 2, 2020 19:03
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 2, 2020
@bedevere-bot bedevere-bot added the awaiting core review label May 2, 2020
remilapeyre
remilapeyre reviewed May 2, 2020
View reviewed changes

@remilapeyre remilapeyre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think there is a typo in the warning message.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/random.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed May 2, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry in What's New.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/random.rst Outdated
Comment on lines +211 to +212
.. deprecated:: 3.9
In the future, the optional argument *random* will be removed.

@serhiy-storchaka serhiy-storchaka May 2, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the shuffle() function is deprecated. It should be specified that the argument is deprecated.

You can also use the deprecated-removed directive to specify the version of removing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/random.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
rhettinger and others added 4 commits May 2, 2020 15:08
@rhettinger Rémi Lapeyre
Update Lib/random.py
a88e3f5 
Co-authored-by: Rémi Lapeyre <[email protected]>
@rhettinger @serhiy-storchaka
Update Lib/random.py
a1f662c 
Co-authored-by: Serhiy Storchaka <[email protected]>
@rhettinger
Apply deprecated-removed tag
31f457a
@rhettinger
Merge branch 'deprecate_shuffle_param' of github.com:rhettinger/cpyth…
f4a74e1 
…on into deprecate_shuffle_param
@rhettinger
rhettinger merged commit 190fac9 into python:master May 2, 2020
@bedevere-bot

bedevere-bot commented May 2, 2020

Copy link
Copy Markdown

@rhettinger: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 2, 2020
@AlexWaygood AlexWaygood mentioned this pull request Feb 14, 2023
gh-101693: In sqlite3, deprecate using named placeholders with parameters supplied as a sequence #101698
Merged
@rhettinger rhettinger mentioned this pull request Aug 23, 2023
Deprecate the optional *random* argument to random.shuffle() #84645
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
+1 more reviewer
@remilapeyre remilapeyre remilapeyre left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rhettinger @bedevere-bot @serhiy-storchaka @remilapeyre @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.