GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-40355: Improve error messages in ast.literal_eval with malformed Dict nodes (GH-19868) by miss-islington · Pull Request #19947 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 5, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Co-authored-by: Pablo Galindo [email protected]
(cherry picked from commit c21c512)

Co-authored-by: Curtis Bucher [email protected]

https://bugs.python.org/issue40355

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@curtisbucher @miss-islington
bpo-40355: Improve error messages in ast.literal_eval with malformed …
2ceb5f0 
…Dict nodes (pythonGH-19868)

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit c21c512)

Co-authored-by: Curtis Bucher <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 5, 2020
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2020
bpo-40355: ast.literal_eval rejects malformed Dict nodes #19868
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels May 5, 2020
pablogsal
pablogsal approved these changes May 5, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 5, 2020
@pablogsal pablogsal closed this May 5, 2020
@miss-islington
miss-islington deleted the backport-c21c512-3.8 branch May 5, 2020 19:49
@miss-islington

miss-islington commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

@curtisbucher and @pablogsal: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 2a3b876 into python:3.8 May 5, 2020
@miss-islington

miss-islington commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

@curtisbucher and @pablogsal: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

@curtisbucher and @pablogsal: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot @curtisbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.