GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] issue-25872: Fix KeyError using linecache from multiple threads (GH-18007) by miss-islington · Pull Request #20080 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 13, 2020

Copy link
Copy Markdown
Contributor

The crash that this fixes occurs when using traceback and other modules from multiple threads;
del cache[filename] can raise a KeyError.
(cherry picked from commit d72ea60)

Co-authored-by: Michael Graczyk [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mgraczyk @miss-islington
issue-25872: Fix KeyError using linecache from multiple threads (pyth…
80b1444 
…onGH-18007)

The crash that this fixes occurs when using traceback and other modules from multiple threads;
del cache[filename] can raise a KeyError.
(cherry picked from commit d72ea60)

Co-authored-by: Michael Graczyk <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 13, 2020
@bedevere-bot bedevere-bot mentioned this pull request May 13, 2020
bpo-25872: Fix KeyError in linecache when multithreaded #18007
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels May 13, 2020
@miss-islington

miss-islington commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

@mgraczyk and @akuchling: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

@mgraczyk and @akuchling: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akuchling akuchling self-assigned this May 14, 2020
@akuchling akuchling closed this May 14, 2020
@miss-islington
miss-islington deleted the backport-d72ea60-3.7 branch May 14, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@akuchling akuchling

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @akuchling @the-knights-who-say-ni @bedevere-bot @mgraczyk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.