GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-40597: email: Use CTE if lines are longer than max_line_length consistently (gh-20038) by miss-islington · Pull Request #20084 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 14, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

raw_data_manager (default for EmailPolicy, EmailMessage)
does correct wrapping of 'text' parts as long as the message contains
characters outside of 7bit US-ASCII set: base64 or qp
Content-Transfer-Encoding is applied if the lines would be too long
without it. It did not, however, do this for ascii-only text,
which could result in lines that were longer than
policy.max_line_length or even the rfc 998 maximum.

This changeset fixes the heuristic so that if lines are longer than
policy.max_line_length, it will always apply a
content-transfer-encoding so that the lines are wrapped correctly.
(cherry picked from commit 6f2f475)

Co-authored-by: Arkadiusz Hiler [email protected]

https://bugs.python.org/issue40597

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ivyl @miss-islington
bpo-40597: email: Use CTE if lines are longer than max_line_length co…
0533c23
…nsistently (pythongh-20038)

raw_data_manager (default for EmailPolicy, EmailMessage)
does correct wrapping of 'text' parts as long as the message contains
characters outside of 7bit US-ASCII set: base64 or qp
Content-Transfer-Encoding is applied if the lines would be too long
without it.  It did not, however, do this for ascii-only text,
which could result in lines that were longer than
policy.max_line_length or even the rfc 998  maximum.

This changeset fixes the heuristic so that if lines are longer than
policy.max_line_length, it will always apply a
content-transfer-encoding so that the lines are wrapped correctly.
(cherry picked from commit 6f2f475)

Co-authored-by: Arkadiusz Hiler <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner May 14, 2020 00:53
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 14, 2020
@bedevere-bot bedevere-bot added the awaiting review label May 14, 2020
@miss-islington

miss-islington commented May 14, 2020

Copy link
Copy Markdown
Contributor Author

@ivyl and @bitdancer: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

2 similar comments
@miss-islington

miss-islington commented May 14, 2020

Copy link
Copy Markdown
Contributor Author

@ivyl and @bitdancer: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented May 14, 2020

Copy link
Copy Markdown
Contributor Author

@ivyl and @bitdancer: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bitdancer
bitdancer merged commit c1f1ddf into python:3.8 May 18, 2020
@bedevere-bot bedevere-bot removed the awaiting review label May 18, 2020
@miss-islington
miss-islington deleted the backport-6f2f475-3.8 branch May 18, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @bitdancer @the-knights-who-say-ni @bedevere-bot @ivyl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.