GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert 19108 remove c element tree by serhiy-storchaka · Pull Request #20116 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 15, 2020

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
serhiy-storchaka and others added 30 commits May 5, 2020 14:55
@serhiy-storchaka
Update docs.
8dc3917
@vstinner
bpo-40513: Per-interpreter signals pending (pythonGH-19924)
4e01946
Move signals_pending from _PyRuntime.ceval to
PyInterpreterState.ceval.
@vstinner
bpo-40513: Per-interpreter gil_drop_request (pythonGH-19927)
0b1e330
Move gil_drop_request member from _PyRuntimeState.ceval to
PyInterpreterState.ceval.
@vstinner
bpo-40514: Add --with-experimental-isolated-subinterpreters (pythonGH…
c5fa364
…-19926)

Add --with-experimental-isolated-subinterpreters build option to
configure: better isolate subinterpreters, experimental build mode.

When used, force the usage of the libc malloc() memory allocator,
since pymalloc relies on the unique global interpreter lock (GIL).
@kingbuzzman
bpo-32117: Updated Simpsons names in docs (pythonGH-19737)
627f701
`sally` is not a Simpsons character

Automerge-Triggered-By: @gvanrossum
@vstinner
bpo-40513: Per-interpreter recursion_limit (pythonGH-19929)
4e30ed3
Move recursion_limit member from _PyRuntimeState.ceval to
PyInterpreterState.ceval.

* Py_SetRecursionLimit() now only sets _Py_CheckRecursionLimit
  of ceval.c if the current Python thread is part of the main
  interpreter.
* Inline _Py_MakeEndRecCheck() into _Py_LeaveRecursiveCall().
* Convert _Py_RecursionLimitLowerWaterMark() macro into a static
  inline function.
@vstinner
bpo-29587: _PyErr_ChainExceptions() checks exception (pythonGH-19902)
b0be6b3
_PyErr_ChainExceptions() now ensures that the first parameter is an
exception type, as done by _PyErr_SetObject().

* The following function now check PyExceptionInstance_Check() in an
  assertion using a new _PyBaseExceptionObject_cast() helper
  function:

  * PyException_GetTraceback(), PyException_SetTraceback()
  * PyException_GetCause(), PyException_SetCause()
  * PyException_GetContext(), PyException_SetContext()

* PyExceptionClass_Name() now checks PyExceptionClass_Check() with an
  assertion.

* Remove XXX comment and add gi_exc_state variable to _gen_throw().

* Remove comment from test_generators
@shihai1991
bpo-40520: Remove redundant comment in pydebug.h (pythonGH-19931)
6351d9e
Automerge-Triggered-By: @corona10
@vstinner
Revert "bpo-40513: Per-interpreter signals pending (pythonGH-19924)" (p…
299b8c6
…ythonGH-19932)

This reverts commit 4e01946.
@vstinner
bpo-40521: Disable Unicode caches in isolated subinterpreters (python…
607b102
…GH-19933)

When Python is built in the experimental isolated subinterpreters
mode, disable Unicode singletons and Unicode interned strings since
they are shared by all interpreters.

Temporary workaround until these caches are made per-interpreter.
@zooba
bpo-40458: Increase reserved stack space to prevent overflow crash on…
ac4bf42
… Windows (pythonGH-19845)
@vstinner
bpo-40521: Disable free lists in subinterpreters (pythonGH-19937)
b4b5386
When Python is built with experimental isolated interpreters, disable
tuple, dict and free free lists.

Temporary workaround until these caches are made per-interpreter.

Add frame_alloc() and frame_get_builtins() subfunctions to simplify
_PyFrame_New_NoTrack().
@vstinner
bpo-40522: _PyThreadState_Swap() sets autoTSSkey (pythonGH-19939)
e838a93
In the experimental isolated subinterpreters build mode,
_PyThreadState_GET() gets the autoTSSkey variable and
_PyThreadState_Swap() sets the autoTSSkey variable.

* Add _PyThreadState_GetTSS()
* _PyRuntimeState_GetThreadState() and _PyThreadState_GET()
  return _PyThreadState_GetTSS()
* PyEval_SaveThread() sets the autoTSSkey variable to current Python
  thread state rather than NULL.
* eval_frame_handle_pending() doesn't check that
  _PyThreadState_Swap() result is NULL.
* _PyThreadState_Swap() gets the current Python thread state with
  _PyThreadState_GetTSS() rather than
  _PyRuntimeGILState_GetThreadState().
* PyGILState_Ensure() no longer checks _PyEval_ThreadsInitialized()
  since it cannot access the current interpreter.
@vstinner
bpo-40513: new_interpreter() init GIL earlier (pythonGH-19942)
0dd5e7a
Fix also code to handle init_interp_main() failure.
@vstinner
bpo-40513: Per-interpreter GIL (pythonGH-19943)
7be4e35
In the experimental isolated subinterpreters build mode, the GIL is
now per-interpreter.

Move gil from _PyRuntimeState.ceval to PyInterpreterState.ceval.

new_interpreter() always get the config from the main interpreter.
@vstinner
bpo-40513: _xxsubinterpreters.run_string() releases the GIL (pythonGH…
fb2c7c4
…-19944)

In the experimental isolated subinterpreters build mode,
_xxsubinterpreters.run_string() now releases the GIL.
@curtisbucher @pablogsal
bpo-40355: Improve error messages in ast.literal_eval with malformed …
c21c512
…Dict nodes (pythonGH-19868)

Co-authored-by: Pablo Galindo <[email protected]>
@sweeneyde
bpo-40504: Allow weakrefs to lru_cache objects (pythonGH-19938)
1253c3e
@pablogsal
bpo-40523: Add pass-throughs for hash() and reversed() to weakref.pro…
96074de
…xy objects (pythonGH-19946)
@tim-one
bpo-40480 "fnmatch" exponential execution time (pythonGH-19908)
b9c46a2
bpo-40480:  create different regexps in the presence of multiple `*`
patterns to prevent fnmatch() from taking exponential time.
@isidentical
bpo-40517: Implement syntax highlighting support for ASDL (python#19928)
d60040b
@rhettinger
Revert "bpo-40517: Implement syntax highlighting support for ASDL (py…
eff870b
…thon#19928)" (python#19950)

This reverts commit d60040b.
@vstinner
bpo-40527: Fix command line argument parsing (pythonGH-19955)
2668a9a
@isidentical
bpo-40528: Improve and clear several aspects of the ASDL definition c…
091951a
…ode for the AST (pythonGH-19952)
@vstinner
bpo-40521: Disable method cache in subinterpreters (pythonGH-19960)
89fc4a3
When Python is built with experimental isolated interpreters, disable
the type method cache.

Temporary workaround until the cache is made per-interpreter.
@vstinner
bpo-40533: Disable GC in subinterpreters (pythonGH-19961)
d8135e9
When Python is built with experimental isolated interpreters, a
garbage collection now does nothing in an isolated interpreter.

Temporary workaround until subinterpreters stop sharing Python
objects.
@vstinner
bpo-40521: Disable list free list in subinterpreters (pythonGH-19959)
b7aa23d
When Python is built with experimental isolated interpreters, disable
the list free list.

Temporary workaround until this cache is made per-interpreter.
@lysnikolaou
bpo-40334: Add type to the assignment rule in the grammar file (pytho…
999ec9a
…nGH-19963)
@naglis
Fix typo in sqlite3 documentation (pythonGH-19965)
441416c
*first* is repeated twice.
@pablogsal
bpo-40334: Allow trailing comma in parenthesised context managers (py…
99db2a1
…thonGH-19964)
vstinner and others added 23 commits May 14, 2020 18:05
@vstinner
bpo-40549: posixmodule.c uses defining_class (pythonGH-20075)
97f33c3
Pass PEP 573 defining_class to os.DirEntry methods. The module state
is now retrieve from defining_class rather than Py_TYPE(self), to
support subclasses (even if DirEntry doesn't support subclasses yet).

* Pass the module rather than defining_class to DirEntry_fetch_stat().
* Only get the module state once in _posix_clear(),
  _posix_traverse() and _posixmodule_exec().
@vstinner
Revert "bpo-32604: [_xxsubinterpreters] Propagate exceptions. (python…
f2c3b68
…GH-19768)" (pythonGH-20089)

* Revert "bpo-40613: Remove compiler warning from _xxsubinterpretersmodule (pythonGH-20069)"

This reverts commit fa0a66e.

* Revert "bpo-32604: [_xxsubinterpreters] Propagate exceptions. (pythonGH-19768)"

This reverts commit a1d9e0a.
@vstinner
bpo-40602: Write unit tests for _Py_hashtable_t (pythonGH-20091)
a482dc5
Cleanup also hashtable.c.
Rename _Py_hashtable_t members:

* Rename entries to nentries
* Rename num_buckets to nbuckets
@pablogsal
bpo-40619: Correctly handle error lines in programs without file mode (…
bcc3036
…pythonGH-20090)
@lysnikolaou @pablogsal
bpo-40618: Disallow invalid targets in augassign and except clauses (p…
ce21cfc
…ythonGH-20083)

This commit fixes the new parser to disallow invalid targets in the
following scenarios:
- Augmented assignments must only accept a single target (Name,
  Attribute or Subscript), but no tuples or lists.
- `except` clauses should only accept a single `Name` as a target.

Co-authored-by: Pablo Galindo <[email protected]>
@vstinner
bpo-40602: _Py_hashtable_set() reports rehash failure (pythonGH-20077)
d2dc827
If _Py_hashtable_set() fails to grow the hash table (rehash), it now
fails rather than ignoring the error.
@FFY00
bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (pythonG…
75d7257
…H-19983)

Signed-off-by: Filipe Laíns <[email protected]>
@vstinner
bpo-40460: Fix typo in idlelib/zzdummy.py (pythonGH-20093)
edf2643
Replace ztest with ztext.
@vstinner
bpo-40462: Fix typo in test_json (pythonGH-20094)
4b972fa
@nanjekyejoannah nanjekyejoannah
bpo-38872: Document exec symbol for codeop.compile_command (pythonGH-…
7ba1f75
…20047)

* Document exec symbol for codeop.compile_command

* Remove extra statements

Co-authored-by: nanjekyejoannah <[email protected]>
@pablogsal @lysnikolaou
bpo-40334: Correctly identify invalid target in assignment errors (py…
16ab070
…thonGH-20076)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@FFY00
bpo-40548: github actions: pass the changes check on no source changes (
6a78589
pythonGH-20097)

Signed-off-by: Filipe Laíns <[email protected]>
@cjerdonek
Update code comment re: location of struct _is. (pythonGH-20067)
1aa8767
@gvanrossum
bpo-40612: Fix SyntaxError edge cases in traceback formatting (python…
15bc9ab
…GH-20072)

This fixes both the traceback.py module and the C code for formatting syntax errors (in Python/pythonrun.c). They now both consistently do the following:

- Suppress caret if it points left of text
- Allow caret pointing just past end of line
- If caret points past end of line, clip to *just* past end of line

The syntax error formatting code in traceback.py was mostly rewritten; small, subtle changes were applied to the C code in pythonrun.c.

There's still a difference when the text contains embedded newlines. Neither handles these very well, and I don't think the case occurs in practice.

Automerge-Triggered-By: @gvanrossum
@cjerdonek
Fix typo in code comment in main_loop label. (pythonGH-20068)
4a12d12
@AndrewGYork
Trivial typo fix in _tkinter.c (pythonGH-19622)
003708b
Change spelling of a #define in _tkinter.c from HAVE_LIBTOMMAMTH to HAVE_LIBTOMMATH, since this is used to keep track of tclTomMath.h, not tclTomMamth.h. No other file seems to refer to this variable.
@vstinner
bpo-40055: test_distutils leaves warnings filters unchanged (pythonGH…
6e57237
…-20095)

distutils.tests now saves/restores warnings filters to leave them
unchanged. Importing tests imports docutils which imports
pkg_resources which adds a warnings filter.
@tiran
bpo-40479: Fix hashlib issue with OpenSSL 3.0.0 (pythonGH-20107)
16d4e6f
OpenSSL 3.0.0-alpha2 was released today. The FIPS_mode() function has
been deprecated and removed. It no longer makes sense with the new
provider and context system in OpenSSL 3.0.0.

EVP_default_properties_is_fips_enabled() is good enough for our needs in
unit tests. It's an internal API, too.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
bpo-40479: Test with latest OpenSSL versions (pythonGH-20108)
62d618c
* 1.0.2u (EOL)
* 1.1.0l (EOL)
* 1.1.1g
* 3.0.0-alpha2 (disabled for now)

Build the FIPS provider and create a FIPS configuration file for OpenSSL
3.0.0.

Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: @tiran
@serhiy-storchaka
Merge branch 'revert-19108-remove-cElementTree' of https://github.com…
60e8085
…/python/cpython into revert-19108-remove-cElementTree
@serhiy-storchaka
Merge branch 'master' into revert-19108-remove-cElementTree
d577e9b
@serhiy-storchaka
Update NEWS.
8d39d0a
@serhiy-storchaka
Merge branch 'revert-19108-remove-cElementTree' of https://github.com…
55e413a
…/python/cpython into revert-19108-remove-cElementTree
@bedevere-bot bedevere-bot added the awaiting core review label May 15, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 15, 2020
@serhiy-storchaka
serhiy-storchaka merged commit 35846fd into python:revert-19108-remove-cElementTree May 15, 2020
@bedevere-bot

bedevere-bot commented May 15, 2020

Copy link
Copy Markdown

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label May 15, 2020
@serhiy-storchaka
serhiy-storchaka deleted the revert-19108-remove-cElementTree branch May 15, 2020 18:31
@serhiy-storchaka
serhiy-storchaka restored the revert-19108-remove-cElementTree branch May 15, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

19 participants

@serhiy-storchaka @bedevere-bot @vstinner @the-knights-who-say-ni @kingbuzzman @shihai1991 @zooba @curtisbucher @sweeneyde @pablogsal @tim-one @isidentical @rhettinger @lysnikolaou @naglis @corona10 @encukou @ericsnowcurrently @ZackerySpytz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.