GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40778: Update Py_REFCNT and Py_SIZE to const casting by corona10 · Pull Request #20428 · python/cpython

Conversation

@corona10

@corona10 corona10 commented May 26, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40778

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-40778: Update Py_REFCNT and Py_SIZE to const casting
9ba5c43
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 26, 2020
@bedevere-bot bedevere-bot added the awaiting core review label May 26, 2020
@corona10
corona10 requested a review from vstinner May 26, 2020 14:08
vstinner
vstinner reviewed May 26, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/C API/2020-05-26-23-06-59.bpo-40778.7cumE-.rst
@@ -0,0 +1,2 @@
Update :c:macro:`Py_SIZE` and :c:macro:`Py_SIZE` to use const object
casting. Patch by Dong-hee Na.

@vstinner vstinner May 26, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that it deserves to be documented. It doesn't change the C API, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/arraymodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10 @vstinner
Update Modules/arraymodule.c
e3d62bd 
Co-authored-by: Victor Stinner <[email protected]>
@corona10 corona10 closed this May 26, 2020
@vstinner

vstinner commented May 26, 2020

Copy link
Copy Markdown
Member

I created PR #20429.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.