GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "bpo-32604: PEP 554 for use in test suite (GH-19985)" by pablogsal · Pull Request #20465 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented May 27, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 9d17cbf.

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
Revert "bpo-32604: PEP 554 for use in test suite (pythonGH-19985)"
21597b0 
This reverts commit 9d17cbf.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 27, 2020
@pablogsal
pablogsal requested a review from vstinner May 27, 2020 20:35
@bedevere-bot bedevere-bot added the awaiting core review label May 27, 2020
@pablogsal
pablogsal requested a review from nanjekyejoannah May 27, 2020 20:35
vstinner
vstinner approved these changes May 27, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with https://bugs.python.org/issue32604#msg370130 to revert.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 27, 2020
nanjekyejoannah
nanjekyejoannah approved these changes May 27, 2020
View reviewed changes
@nanjekyejoannah

nanjekyejoannah commented May 27, 2020

Copy link
Copy Markdown
Contributor

You can revert until I look probably this weekend
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 7d80b35 into python:master May 27, 2020
@bedevere-bot

bedevere-bot commented May 27, 2020

Copy link
Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 27, 2020
@vstinner

vstinner commented May 27, 2020

Copy link
Copy Markdown
Member

You can revert until I look probably this weekend

Ok, thanks @nanjekyejoannah. I merged the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal deleted the revert_interpreters branch May 19, 2021 18:57
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @nanjekyejoannah @bedevere-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.