GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (GH-20493) by miss-islington · Pull Request #20495 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Recent changes to _datetimemodule broke compilation on mingw; see the comments in this change for details.

FWIW, @corona10: this issue is why PyType_FromModuleAndSpec & friends take the bases argument at run time.
(cherry picked from commit 459acc5)

Co-authored-by: Petr Viktorin [email protected]

https://bugs.python.org/issue40777

Automerge-Triggered-By: @encukou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou @miss-islington
bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-t…
5bfea4a 
…ime (pythonGH-20493)

Recent changes to _datetimemodule broke compilation on mingw; see the comments in this change for details.

FWIW, @corona10: this issue is why `PyType_FromModuleAndSpec` & friends take the `bases` argument at run time.
(cherry picked from commit 459acc5)

Co-authored-by: Petr Viktorin <[email protected]>
@miss-islington
miss-islington requested review from abalkin and pganssle as code owners May 28, 2020 16:15
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 28, 2020
@bedevere-bot bedevere-bot mentioned this pull request May 28, 2020
bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time #20493
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 28, 2020
@miss-islington

miss-islington commented May 28, 2020

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes May 28, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 28, 2020
@miss-islington

miss-islington commented May 28, 2020

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the 🤖 automerge label May 28, 2020
@miss-islington
miss-islington merged commit eceee54 into python:3.9 May 28, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label May 28, 2020
@miss-islington
miss-islington deleted the backport-459acc5-3.9 branch May 28, 2020 16:41
@miss-islington

miss-islington commented May 28, 2020

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented May 28, 2020

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @encukou @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.