GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.9] Further de-linting of zoneinfo module (GH-20499) by miss-islington · Pull Request #20515 · python/cpython

Conversation

miss-islington commented May 29, 2020

Copy link

Copy Markdown

Contributor

Remove unused imports in zoneinfo
Remove unused variables in zoneinfo
Remove else after raise
(cherry picked from commit 364b5ea)

Co-authored-by: Paul Ganssle [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Further de-linting of zoneinfo module (pythonGH-20499)

4e7bcef

* Remove unused imports in zoneinfo

* Remove unused variables in zoneinfo

* Remove else after raise
(cherry picked from commit 364b5ea)

Co-authored-by: Paul Ganssle <[email protected]>

the-knights-who-say-ni added the CLA signed label

May 29, 2020

bedevere-bot mentioned this pull request

May 29, 2020

Further de-linting of zoneinfo module #20499

Merged

bedevere-bot added skip issue skip news awaiting review labels

May 29, 2020

pganssle approved these changes

May 29, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

May 29, 2020

miss-islington commented May 29, 2020

Copy link

Copy Markdown

Contributor Author

@pganssle: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington merged commit 805fa54 into python:3.9

May 29, 2020

bedevere-bot removed the awaiting merge label

May 29, 2020

miss-islington deleted the backport-364b5ea-3.9 branch

May 29, 2020 13:53

miss-islington commented May 29, 2020

Copy link

Copy Markdown

Contributor Author

@pganssle: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

miss-islington commented May 29, 2020

Copy link

Copy Markdown

Contributor Author

@pganssle: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

pganssle

pganssle approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.