GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-39885: Make IDLE context menu cut and copy work again (GH-18951) by miss-islington · Pull Request #20523 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 29, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Leave selection when right click within. This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d. I did not realize that this completely disabled the context menu entries, and I should have merged a minimal fix immediately. An automated test should follow.
(cherry picked from commit 97e4e0f)

Co-authored-by: Terry Jan Reedy [email protected]

https://bugs.python.org/issue39885

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy @miss-islington
bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-1…
719d858 
…8951)

Leave selection when right click within.  This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d.  I did not realize that this completely disabled the context menu entries, and  I should have merged a minimal fix immediately.  An automated test should follow.
(cherry picked from commit 97e4e0f)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner May 29, 2020 22:54
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 29, 2020
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label May 29, 2020
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2020
bpo-39885: IDLE: Leave selection when right click within #18951
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 29, 2020
terryjreedy
terryjreedy approved these changes May 29, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 29, 2020
@miss-islington

miss-islington commented May 29, 2020

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 3dcccd1 into python:3.8 May 29, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label May 29, 2020
@miss-islington
miss-islington deleted the backport-97e4e0f-3.8 branch May 29, 2020 23:13
@miss-islington

miss-islington commented May 29, 2020

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented May 29, 2020

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @terryjreedy @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.