GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Recommit "bpo-32604: PEP 554 for use in test suite (GH-19985)" by nanjekyejoannah · Pull Request #20611 · python/cpython

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Jun 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Recommit of what was reverted in 9d17cbf

The refleak in the select module was fixed in a separate PR

With this fix, the tests pass:

gitpod /workspace/cpython $ ./python -m test -R 3:3 test_interpreters
0:00:00 load avg: 4.74 Run tests sequentially
0:00:00 load avg: 4.74 [1/1] test_interpreters
beginning 6 repetitions
123456
......
test_interpreters passed in 1 min 9 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 min 9 sec
Tests result: SUCCESS

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
nanjekyejoannah and others added 13 commits May 7, 2020 18:51
nanjekyejoannah
PEP 554 for use in test suite
02086f7
@blurb-it
📜🤖 Added by blurb_it.
b2fda3c
nanjekyejoannah
Fix space
3667626
nanjekyejoannah
Add doc to doc tree
cb594dd
nanjekyejoannah
Move to modules doc tree
0448a8a
nanjekyejoannah
Fix suspicious doc errors
85fde9f
nanjekyejoannah
Fix test__all
f6af61c
nanjekyejoannah
Docs docs docs
0decbee
@nanjekyejoannah
Support isolated and fix wait
3b35e1b
@nanjekyejoannah
Fix white space
af90b25
@nanjekyejoannah
Remove undefined from __all__
90ec54b
@nanjekyejoannah
Fix recv and add exceptions
049aa3a
@nanjekyejoannah
Remove unused exceptions, fix pep 8 formatting errors and fix _NOT_SE…
9577395 
…T in recv_nowait()
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 3, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jun 3, 2020
@nanjekyejoannah
nanjekyejoannah requested review from pablogsal and vstinner June 3, 2020 14:17
@vstinner

vstinner commented Jun 3, 2020

Copy link
Copy Markdown
Member

Sorry, I don't have the bandwidth to review this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah

nanjekyejoannah commented Jun 3, 2020

Copy link
Copy Markdown
Contributor Author

The contents of this PR were already reviewed by @ericsnowcurrently . The only confirmation here is to confirm that no leaks make the tests fail which I already did. There are no changes to what had been merged before
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 3, 2020
@bedevere-bot

bedevere-bot commented Jun 3, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 9577395 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 3, 2020
pablogsal
pablogsal reviewed Jun 3, 2020
View reviewed changes
Comment thread Lib/test/support/interpreters.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jun 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I didn't review this but I am confused....why there is an rst file with documentation in the test directory?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah

nanjekyejoannah commented Jun 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@pablogsal, I think the discussion around this was Eric said we needed to have a reference to the added API in test.support . We could not add the document file in Doc/library/* before the API moved to stdlib. You can follow the discussion here: #19985

Edit:

I have looked and do not see docs anywhere else other than the Docs folder though. So am okay removing the .rst for this PR until consensus is reached.
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nanjekyejoannah and others added 2 commits June 3, 2020 18:30
@nanjekyejoannah @pablogsal
Update Lib/test/support/interpreters.py
7370a9c 
Co-authored-by: Pablo Galindo <[email protected]>
@nanjekyejoannah
Remove documentation (module is for internal use)
d5f2579
@nanjekyejoannah

nanjekyejoannah commented Jun 5, 2020

Copy link
Copy Markdown
Contributor Author

@pablogsal I decided to remove the docs. I hope this is okay now.
pablogsal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently
ericsnowcurrently approved these changes Jun 5, 2020
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM As I said when I reviewed the original PR, this is a good start. :) Thanks for doing this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 5, 2020
@bedevere-bot bedevere-bot added the awaiting merge label Jun 5, 2020
@nanjekyejoannah
nanjekyejoannah merged commit bae872f into python:master Jun 10, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 10, 2020
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal left review comments
@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@nanjekyejoannah @vstinner @bedevere-bot @pablogsal @ericsnowcurrently @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.