GeezerVison is showing github.com — [WIP] bpo-1635741: Py_Finalize() finalizes builtin static types by vstinner · Pull Request #20763 · python/cpython
Conversation
vstinner
commented
Jun 9, 2020
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Clear the following PyTypeObject members of builtin static types in
Py_Finalize():
- tp_bases
- tp_cache
- tp_dict
- tp_mro
- tp_subclasses
Finalize static types initialized by _PyStaticTypes_Init() and
builtin exceptions initialized by _PyExc_Init().
Once a static type is finalized, it must no longer be used.
Use assert(!_PyStaticType_IsFinalized(type)); to ensure that static
type is not finalized.
With this change, Valgrind log:
possibly lost: 612,326 bytes in 5,503 blocks
becomes:
possibly lost: 369,346 bytes in 2,805 blocks"
Changes:
- Rename _PyTypes_Init() to _PyStaticTypes_Init().
- Move _PyExc_Fini() call inside finalize_interp_types().
https://bugs.python.org/issue1635741
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Clear the following PyTypeObject members of builtin static types in
Py_Finalize():
* tp_bases
* tp_cache
* tp_dict
* tp_mro
* tp_subclasses
Finalize static types initialized by _PyStaticTypes_Init() and
builtin exceptions initialized by _PyExc_Init().
Once a static type is finalized, it must no longer be used.
Use assert(!_PyStaticType_IsFinalized(type)); to ensure that static
type is not finalized.
With this change, Valgrind log:
possibly lost: 612,326 bytes in 5,503 blocks
becomes:
possibly lost: 369,346 bytes in 2,805 blocks"
Changes:
* Rename _PyTypes_Init() to _PyStaticTypes_Init().
* Move _PyExc_Fini() call inside finalize_interp_types().
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.