GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port _dbm module to multiphase initialization by corona10 · Pull Request #20848 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jun 13, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-1635741: Port _dbm module to multiphase initialization
7736a6b
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 13, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jun 13, 2020
@corona10
corona10 requested a review from vstinner June 13, 2020 01:49
@corona10

corona10 commented Jun 13, 2020

Copy link
Copy Markdown
Member Author

@shihai1991 PTAL!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Jun 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I' ve checked the memory leak with these scripts and no leaks found

./python.exe -m test test_dbm  -R 3:3

def test_dbm(self):
    code = textwrap.dedent(r"""
        import glob

        import test.support
        dbm = test.support.import_module('_dbm')
        _fname = test.support.TESTFN

        def delete_files():
            for f in glob.glob(_fname + "*"):
                test.support.unlink(f)

        f = dbm.open(_fname, 'n')
        f[b'g'] = b"indented"
        f.close()
       delete_files()
    """)
    ret = test.support.run_in_subinterp(code)
    self.assertEqual(ret, 0)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 reviewed Jun 13, 2020
View reviewed changes
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits June 13, 2020 17:54
@corona10
bpo-1635741: Apply PEP 7
ce98ee9
@corona10
bpo-1635741: Apply PEP 7
f0371c6
corona10
corona10 commented Jun 13, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shihai1991 Thanks shihai! I've updated it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shihai1991
shihai1991 approved these changes Jun 13, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner requested changes Jun 15, 2020
View reviewed changes
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 15, 2020
@bedevere-bot

bedevere-bot commented Jun 15, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jun 15, 2020
@corona10
bpo-1635741: Apply Victor's review
7ec3d5c
corona10
corona10 commented Jun 15, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes; please review again

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested a review from vstinner June 15, 2020 15:05
vstinner
vstinner reviewed Jun 15, 2020
View reviewed changes
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jun 15, 2020
View reviewed changes
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-1635741: Apply Victor's review
4a69834
vstinner
vstinner reviewed Jun 15, 2020
View reviewed changes
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 and others added 2 commits June 16, 2020 00:20
@corona10
bpo-1635741: reformat macro
87a6ef1
@corona10 @vstinner
Update Modules/_dbmmodule.c
b325856 
Co-authored-by: Victor Stinner <[email protected]>
@corona10
corona10 force-pushed the bpo-1635741-dbm branch from 26030f1 to b325856 Compare June 15, 2020 15:21
@corona10
bpo-1635741: Apply code review
46d7c69
@corona10
corona10 requested a review from vstinner June 15, 2020 15:24
vstinner
vstinner reviewed Jun 15, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's now much better!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-1635741: Update
ae11a49
@corona10
corona10 requested a review from vstinner June 15, 2020 15:56
vstinner
vstinner approved these changes Jun 15, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Jun 15, 2020
@corona10
corona10 merged commit bf69a8f into python:master Jun 15, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 15, 2020
@corona10
corona10 deleted the bpo-1635741-dbm branch June 15, 2020 16:21
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@shihai1991 shihai1991 shihai1991 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @bedevere-bot @vstinner @shihai1991 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.