GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-40334: Produce better error messages on invalid targets (GH-20106) by lysnikolaou · Pull Request #20973 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented Jun 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The following error messages get produced:

  • cannot delete ... for invalid del targets
  • ... is an illegal 'for' target for invalid targets in for
    statements
  • ... is an illegal 'with' target for invalid targets in
    with statements

Additionally, a few cuts were added in various places before the
invocation of the invalid_* rule, in order to speed things
up.

Co-authored-by: Pablo Galindo [email protected]
(cherry picked from commit 01ece63)

https://bugs.python.org/issue40334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lysnikolaou @pablogsal
bpo-40334: Produce better error messages on invalid targets (pythonGH…
cc9106b
…-20106)

The following error messages get produced:
- `cannot delete ...` for invalid `del` targets
- `... is an illegal 'for' target` for invalid targets in for
  statements
- `... is an illegal 'with' target` for invalid targets in
  with statements

Additionally, a few `cut`s were added in various places before the
invocation of the `invalid_*` rule, in order to speed things
up.

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 01ece63)
@lysnikolaou
lysnikolaou requested a review from pablogsal as a code owner June 18, 2020 23:31
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 18, 2020
@bedevere-bot bedevere-bot mentioned this pull request Jun 18, 2020
bpo-40334: Produce better error messages on invalid targets #20106
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels Jun 18, 2020
@lysnikolaou
Remove a test from test_syntax that fails with the old parser
53afe79
@pablogsal
pablogsal merged commit a5442b2 into python:3.9 Jun 19, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Jun 19, 2020
pablogsal
pablogsal approved these changes Jun 19, 2020
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Jun 19, 2020
@lysnikolaou
lysnikolaou deleted the backport-01ece63-3.9 branch June 19, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lysnikolaou @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.