GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing by asottile · Pull Request #21104 · python/cpython

Conversation

@asottile

@asottile asottile commented Jun 24, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: inspect. _signature_fromstr has unused code #99815

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 24, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jun 24, 2020
eamanu
eamanu approved these changes Jun 24, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 24, 2020
@asottile
asottile force-pushed the inspect_signature_simplify branch from 5309efa to 847fd9f Compare September 3, 2020 18:10
@asottile
asottile force-pushed the inspect_signature_simplify branch from 847fd9f to e569169 Compare November 2, 2021 02:24
@asottile
asottile force-pushed the inspect_signature_simplify branch from e569169 to 477c2eb Compare July 8, 2022 16:27
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@asottile
asottile force-pushed the inspect_signature_simplify branch from 477c2eb to 83f9192 Compare August 5, 2022 20:22
@asottile

asottile commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

@1st1 (inspect expert) -- been sitting on this small fix for a few years -- any chance of a review ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile
Simplify routine in inspect.signature parsing
e6eaf8e
@asottile
asottile force-pushed the inspect_signature_simplify branch from 83f9192 to e6eaf8e Compare October 5, 2022 21:16
@iritkatriel
Merge branch 'main' into inspect_signature_simplify
9841a06
iritkatriel
iritkatriel approved these changes Nov 27, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 27, 2022
@kumaraditya303 kumaraditya303 added skip issue skip news labels Nov 27, 2022
@iritkatriel iritkatriel changed the title Simplify routine in inspect.signature parsing remove unused 'invalid' variable in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel changed the title remove unused 'invalid' variable in inspect.signature parsing remove unused 'invalid' value in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel changed the title remove unused 'invalid' value in inspect.signature parsing gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel removed the skip issue label Nov 27, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 27, 2022
inspect. _signature_fromstr has unused code #99815
Closed
@iritkatriel
iritkatriel merged commit ac115b5 into python:main Nov 27, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 27, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request Dec 12, 2022
gh-85267: Improvements to inspect.signature __text_signature__ handling #98796
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
+1 more reviewer
@eamanu eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@asottile @iritkatriel @eamanu @the-knights-who-say-ni @ezio-melotti @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.