GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41171: Added method "PyMetaType_FromSpec" to allow for specifying the metaclass for the type. by WildCard65 · Pull Request #21238 · python/cpython

Conversation

@WildCard65

@WildCard65 WildCard65 commented Jun 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue41171

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@WildCard65
bpo-41171: Added companion "FromSpec" methods prefixed with "PyMetaTy…
5e73355 
…pe" to go with the "PyType" variants.
@WildCard65
WildCard65 requested a review from a team as a code owner June 30, 2020 16:29
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 30, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jun 30, 2020
@WildCard65

WildCard65 commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

Paging @vstinner for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jun 30, 2020
View reviewed changes
Comment thread Objects/typeobject.c Outdated

@vstinner vstinner Jun 30, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose the name PyMetaType_FromSpec and remove PyMetaType_FromSpecWithBases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@WildCard65 WildCard65 Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you're suggesting renaming PyMetaType_FromSpecWithBases to just PyMetaType_FromSpec or just keeping the PyMetaType_FromSpec from above?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Jun 30, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename PyMetaType_FromModuleAndSpec (4 parameters) to PyMetaType_FromSpec. And so remove the other PyMetaType_FromSpec (2 parameters).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@WildCard65 WildCard65 Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I move the method out of "Py_LIMITED_API" then?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
WildCard65 and others added 2 commits June 30, 2020 16:58
@WildCard65
Removed 'PyMetaType_FromSpecAndBases'.
745387c 
Added a note about 'PyMetaType_FromModuleAndSpec' in regards to 'tp_new'.
@blurb-it @WildCard65
📜🤖 Added by blurb_it.
e2cde2c
@WildCard65
WildCard65 force-pushed the bpo-41171 branch from 18c96cf to e2cde2c Compare June 30, 2020 21:00
@WildCard65
WildCard65 requested review from vstinner and removed request for a team June 30, 2020 21:01
WildCard65 added 3 commits June 30, 2020 17:02
@WildCard65
Fixed documentation error of 'PyType_FromSpecWithBases'
faa247a
@WildCard65
Fixed dangling function export.
9089911
@WildCard65
Renamed "PyMetaType_FromModuleAndSpec" to "PyMetaType_FromSpec".
1ea9a54 
Removed other "PyMetaType" variants.
@WildCard65

WildCard65 commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner I performed the change you requested.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WildCard65 WildCard65 changed the title bpo-41171: Added companion "FromSpec" methods prefixed with "PyMetaTy… bpo-41171: Added method "PyMetaType_FromSpec" to allow for specifying the metaclass for the type. Jun 30, 2020
@WildCard65
Updated NEWS entry to reflect changes.
df908fe
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@WildCard65 WildCard65 mannequin mentioned this pull request Nov 30, 2022
Create companion methods of "PyType_FromSpec*" to allow setting metaclass. #85343
Closed
@kumaraditya303

kumaraditya303 commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Superseded by #93012
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 closed this Nov 30, 2022
@WildCard65
WildCard65 deleted the bpo-41171 branch November 30, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@WildCard65 @kumaraditya303 @vstinner @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.