GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Release Unicode interned strings at exit by vstinner · Pull Request #21269 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 1, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • PyUnicode_InternInPlace() now ensures that interned strings are
    ready.
  • Add _PyUnicode_ClearInterned().
  • Py_Finalize() now releases Unicode interned strings:
    call _PyUnicode_ClearInterned().

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-1635741: Release Unicode interned strings at exit
316e001 
* PyUnicode_InternInPlace() now ensures that interned strings are
  ready.
* Add _PyUnicode_ClearInterned().
* Py_Finalize() now releases Unicode interned strings:
  call _PyUnicode_ClearInterned().
@vstinner vstinner added the skip news label Jul 1, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 1, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jul 1, 2020
@vstinner

vstinner commented Jul 1, 2020

Copy link
Copy Markdown
Member Author

Python has between 1446 (./python -sSI -c pass command) and 4660 (run 19 tests using ./python -m test and interrupt it after around 19 tests) interned strings at exit.

This PR has no significant impact on timing of the ./python -sSI -c pass command:

# benchmark
$ python3 -m pyperf command -o ref.json -- ./python -sSI -c pass
# switch to the PR branch, make
$ python3 -m pyperf command -o clear.json -- ./python -sSI -c pass

$ python3 -m pyperf show ref.json 
Mean +- std dev: 7.56 ms +- 0.24 ms

$ python3 -m pyperf compare_to ref.json clear.json
Benchmark hidden because not significant (1): command

@shihai1991 proposed PR #21087 to solve the same problem. My PR clears interned strings before calling _PyDict_Fini() and _PyList_Fini(), since _PyUnicode_ClearInterned() uses a dict and a list.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jul 1, 2020
bpo-1635741: Enable unicode_release_interned() without insure or valgrind. #21087
Closed
@vstinner
vstinner merged commit 666ecfb into python:master Jul 1, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 1, 2020
@vstinner
vstinner deleted the clear_interned branch July 1, 2020 23:20
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.