GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port faulthandler module to multiphase initialization by corona10 · Pull Request #21294 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jul 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-1635741: Port faulthandler module to multiphase initialization
cd29a88
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 3, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jul 3, 2020
@corona10
corona10 requested a review from vstinner July 3, 2020 14:34
corona10
corona10 commented Jul 3, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner @shihai1991 PTAL :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner approved these changes Jul 3, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems like your PR introduces a compiler warning on the slots:

"initialization from incompatible pointer type [-Wincompatible-pointer-types]"

It may be good to fix it first.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/faulthandler.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 3, 2020
@corona10
bpo-1635741: fix
fa8b4de
@corona10

corona10 commented Jul 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

"initialization from incompatible pointer type [-Wincompatible-pointer-types]"

Yeah, it should be PyModuleDef_Slot, not PyType_Slot, it was my mistake.
I've fixed the PR, and after the test is passed, I will merge this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jul 3, 2020

Copy link
Copy Markdown
Member

Yeah, it should be PyModuleDef_Slot, not PyType_Slot

Ooops :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 closed this Jul 3, 2020
@corona10 corona10 reopened this Jul 3, 2020
@corona10 corona10 mentioned this pull request Jul 3, 2020
bpo-41194: Convert _ast extension to PEP 489 #21293
Merged
@corona10 corona10 closed this Jul 3, 2020
@corona10 corona10 reopened this Jul 3, 2020
@corona10
corona10 merged commit c0b214b into python:master Jul 3, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 3, 2020
@corona10
corona10 deleted the bpo-1635741-fault branch July 3, 2020 16:36
@vstinner

vstinner commented Jul 3, 2020

Copy link
Copy Markdown
Member

Thanks for taking care of "my" little module :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.