GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39981: Introduce default values for AST node classes by isidentical · Pull Request #21417 · python/cpython

Conversation

@isidentical

@isidentical isidentical commented Jul 9, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue39981

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@isidentical
isidentical requested review from lysnikolaou and pablogsal as code owners July 9, 2020 13:33
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 9, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jul 9, 2020
@isidentical isidentical mentioned this pull request Jul 9, 2020
bpo-39981: Default values for AST nodes #19031
Closed
@isidentical
isidentical force-pushed the bpo-39981-rewrite branch 6 times, most recently from c58fc56 to adeef76 Compare July 14, 2020 14:49
@isidentical
isidentical requested a review from serhiy-storchaka July 14, 2020 20:55
iritkatriel
iritkatriel reviewed Aug 12, 2020
View reviewed changes
Comment thread Lib/ast.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@isidentical isidentical mentioned this pull request Oct 6, 2020
Fix to_source() when optional attributes are missing berkerpeksag/astor#189
Closed
isidentical added 3 commits October 10, 2020 14:31
@isidentical
bpo-39981: Introduce default values for AST node classes
af056d0
@isidentical
fix syntax error at the test
da49fbf
@isidentical
Try to make tests pass on Microsoft C compiler
12a8296
@isidentical
isidentical force-pushed the bpo-39981-rewrite branch from adeef76 to 12a8296 Compare October 10, 2020 11:36
iritkatriel
iritkatriel reviewed Oct 12, 2020
View reviewed changes
Comment thread Parser/asdl_c.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@isidentical
Replace field_defaults => field_qualifiers
e73722a
@MaxwellDupre

MaxwellDupre commented May 20, 2022

Copy link
Copy Markdown
Contributor

Can you re-target for 3.12 (Doc/whatsnew/3.10.rst)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@JelleZijlstra

JelleZijlstra commented May 19, 2024

Copy link
Copy Markdown
Member

I implemented this in #105880; sorry I missed the existence of this PR. This PR also has a ton of merge conflicts now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra closed this May 19, 2024
@isidentical isidentical mentioned this pull request Apr 10, 2022
Default values for AST Nodes #84162
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel left review comments
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@isidentical @MaxwellDupre @JelleZijlstra @iritkatriel @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.