GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-41341: Recursive evaluation of ForwardRef in get_type_hints (GH-21553) by miss-islington · Pull Request #21629 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 26, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.
(cherry picked from commit 653f420)

Co-authored-by: wyfo [email protected]

https://bugs.python.org/issue41341

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wyfo @miss-islington
bpo-41341: Recursive evaluation of ForwardRef in get_type_hints (pyth…
50ebde5 
…onGH-21553)

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.
(cherry picked from commit 653f420)

Co-authored-by: wyfo <[email protected]>
@miss-islington
miss-islington requested review from gvanrossum and ilevkivskyi as code owners July 26, 2020 15:08
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 26, 2020
@bedevere-bot bedevere-bot mentioned this pull request Jul 26, 2020
bpo-41341: Recursive evaluation of ForwardRef in get_type_hints #21553
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jul 26, 2020
@miss-islington

miss-islington commented Jul 26, 2020

Copy link
Copy Markdown
Contributor Author

@wyfo and @gvanrossum: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Jul 26, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 26, 2020
@miss-islington
miss-islington merged commit 41d1c04 into python:3.9 Jul 26, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 26, 2020
@miss-islington
miss-islington deleted the backport-653f420-3.9 branch July 26, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot @wyfo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.