GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41260: C impl of datetime.date.strftime() takes different keyword arg by ZackerySpytz · Pull Request #21712 · python/cpython

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Aug 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The parameter was named "fmt" in the Python implementation, but it
was was named "format" in the C implementation.

https://bugs.python.org/issue41260

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz
bpo-41260: C impl of datetime.date.strftime() takes different keyword…
9132c91 
… arg

The parameter was named "fmt" in the Python implementation, but it
was was named "format" in the C implementation.
@ZackerySpytz
ZackerySpytz requested review from abalkin and pganssle as code owners August 3, 2020 05:50
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 3, 2020
@bedevere-bot bedevere-bot added the awaiting review label Aug 3, 2020
asottile
asottile reviewed Aug 3, 2020
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh uh, I was working through this with a beginner as a mentorship opportunity -- but the patch looks correct and equivalent to what we were doing

there's another function which should be updated as well which has a similar problem

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pganssle
pganssle approved these changes Oct 20, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 20, 2020
@asottile asottile mannequin mentioned this pull request Apr 10, 2022
datetime, date and time: strftime method takes different keyword argument: fmt (pure) or format (C) #85432
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@iritkatriel
Merge branch 'main' into bpo-41260-datetime-strftime-param
7617f86
@iritkatriel

iritkatriel commented Nov 24, 2022

Copy link
Copy Markdown
Member

Should this be backported?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile

asottile commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Should this be backported?

I don't think so -- since it ~technically changes the signatures of the functions slightly
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit b1dcdef into python:main Nov 25, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 25, 2022
@AlexWaygood AlexWaygood mentioned this pull request Dec 4, 2022
gh-85432: Harmonise parameter names between C and pure-Python implementations of datetime.time.strftime, datetime.datetime.fromtimestamp #99993
Merged
@AlexWaygood AlexWaygood mentioned this pull request Dec 27, 2022
datetime: various parameters can now safely be passed as keyword arguments on 3.12+ python/typeshed#9415
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle approved these changes
@abalkin abalkin Awaiting requested review from abalkin
+1 more reviewer
@asottile asottile asottile left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@ZackerySpytz @iritkatriel @asottile @pganssle @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.