GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — bpo-1635741: Fix refleaks of encodings module by removing the encodings._aliases by shihai1991 · Pull Request #21896 · python/cpython Conversation
|
|
I use the test case of https://bugs.python.org/issue1635741#msg355187 to test the refleaks in debug mode. Before this PR: After this PR: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vstinner Hi, victor. Pls take a look if you have free time, thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| def search_function(encoding): | ||
|
|
||
| _aliases = aliases.aliases |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Don't understand the problem.
This statement should be placed at below so that it does not affect the performance of the cache.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Don't understand the problem.
Thanks for your comment. It will affect the encodings module's refcount in C level and reduce the refleaks.
This statement should be placed at below so that it does not affect the performance of the cache.
MAYBE removing this line and using aliases.aliases to replace _aliases is fine too :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looking this comment: #21896 (comment)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looking this comment: #21896 (comment)
The usage of aliases.aliasesis is very normal, maybe the root of the problem is not here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I don't see how using encodings._aliases in search_function() creates a "reference leak". A leak is when calling a function multiple times leaks memory. Here, there is no leak.
Maybe you're talking about a "reference cycle".
I guess that you're trying to clear variables at exit.
You should try to trigger an explicit GC collection after calling PyInterpreterState_Clear(). In finalize_interp_clear(), try to replace:
/* Trigger a GC collection on subinterpreters*/
if (!is_main_interp) {
_PyGC_CollectNoFail();
}
with:
// Last explicit GC collection
_PyGC_CollectNoFail();
(without this change)
Does it fix your issue?
PyInterpreterState_Clear() clears the reference to the search function: Py_CLEAR(interp->codec_search_path).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Thanks, victor. "reference cycle" would be more exact. And I will try your idea in my interpreter. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Oh, amazing result: sys.gettotalrefcount: 10537 the pr in: #21902 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Pablo created this PR(don't calling explict collection in main interpreter): #17457 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Since #17457 is merged, is this PR still relevant/useless? If not, please close it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.