GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40352: Try to reconnect socket when send message in SocketHandler. by serhiy-storchaka · Pull Request #22061 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

TODO: Tests and NEWS.

https://bugs.python.org/issue40352

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-40352: Try to reconnect socket when send message in SocketHandler.
f756737
@serhiy-storchaka
serhiy-storchaka requested a review from vsajip September 2, 2020 09:12
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 2, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Sep 2, 2020
@serhiy-storchaka serhiy-storchaka added needs backport to 3.8 type-bug An unexpected behavior, bug, or error labels Sep 2, 2020
vsajip
vsajip reviewed Sep 3, 2020
View reviewed changes
Comment thread Lib/logging/handlers.py
self.sock = None # so we can call createSocket next time
if attempt:
continue
break

@vsajip vsajip Sep 3, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this code will retry connection once, straight away, if the handler was previously connected but an error occurs when actually sending the event. In the case where the reason for the error is that the remote has gone offline, how likely is that reconnection attempt to succeed? Isn't the remote going offline for a period the case described in the issue?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv ambv removed the needs backport to 3.8 label May 4, 2021
@ambv ambv removed the needs backport to 3.9 label May 17, 2022
@ambv

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OlegNykolyn OlegNykolyn mannequin mentioned this pull request Apr 10, 2022
SocketHandler silently drops log messages on re-connect #84532
Open
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@serhiy-storchaka serhiy-storchaka closed this Oct 6, 2022
@serhiy-storchaka
serhiy-storchaka deleted the sockethandler-reconnect branch October 6, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@serhiy-storchaka @ambv @vsajip @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.