GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41706: Fix dunder operator invocation docs by wchargin · Pull Request #22084 · python/cpython

Conversation

@wchargin

@wchargin wchargin commented Sep 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The expression x + y is evaluated using type(x).__add__, which may
differ from x.__add__ if the __add__ attribute has been directly
assigned on the instance.

Demonstration:

class C:
    def __add__(self, other):
        return "from class"

c = C()
print(c + c)  # prints "from class"

c.__add__ = lambda other: "from instance"
print(c.__add__(c))  # prints "from instance"
print(type(c).__add__(c, c))  # prints "from class"

print(c + c)  # prints "from class"!

wchargin-branch: dunder-op-invocation-docs

https://bugs.python.org/issue41706

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@wchargin
bpo-41706: Fix dunder operator invocation docs
aacce81
The expression `x + y` is evaluated using `type(x).__add__`, which may
differ from `x.__add__` if the `__add__` attribute has been directly
assigned on the instance.

Demonstration:

```python
class C:
    def __add__(self, other):
        return "from class"

c = C()
print(c + c)  # prints "from class"

c.__add__ = lambda other: "from instance"
print(c.__add__(c))  # prints "from instance"
print(type(c).__add__(c, c))  # prints "from class"

print(c + c)  # prints "from class"!
```

wchargin-branch: dunder-op-invocation-docs
wchargin-source: 543786396ecba124a332357c771cfd6b20493abe
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 3, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 3, 2020
@wchargin

wchargin commented Sep 3, 2020

Copy link
Copy Markdown
Contributor Author

Verified that doc updates render correctly in the build output from the
GitHub Action.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ammaraskar

ammaraskar commented Aug 2, 2021

Copy link
Copy Markdown
Member

@brettcannon Do you have an opinion on this tweak to the documentation since you wrote the desugarring blog posts?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon
brettcannon approved these changes Aug 4, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 4, 2021
@brettcannon brettcannon closed this Aug 4, 2021
@brettcannon brettcannon reopened this Aug 4, 2021
@brettcannon
brettcannon merged commit 80f33f2 into python:main Aug 4, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 4, 2021
@brettcannon

brettcannon commented Aug 4, 2021

Copy link
Copy Markdown
Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@wchargin
wchargin deleted the wchargin-dunder-op-invocation-docs branch August 4, 2021 20:45
@wchargin

wchargin commented Aug 4, 2021

Copy link
Copy Markdown
Contributor Author

Thank you!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@wchargin @ammaraskar @brettcannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.