GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85956: update error in documentation by koubaa · Pull Request #22242 · python/cpython

Conversation

@koubaa

@koubaa koubaa commented Sep 14, 2020 •
edited by serhiy-storchaka
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue41790

  • Issue: C-API documentation ignores heap types and says type objects must never be deallocated #85956

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@koubaa
update doc
098273f
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 14, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 14, 2020
@koubaa

koubaa commented Sep 14, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @corona10 @shihai1991 I'm sure I have the wrong issue number but wanted to propose this change to the doc. I can change the number and rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 14, 2020

Copy link
Copy Markdown
Member

@vstinner @corona10 @shihai1991 I'm sure I have the wrong issue number but wanted to propose this change to the doc. I can change the number and rebase.

You have the wrong issue number.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@koubaa koubaa changed the title bpo-1635741: update error in documentation bpo-41790: update error in documentation Sep 15, 2020
@koubaa

koubaa commented Sep 15, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @corona10 @shihai1991 I'm sure I have the wrong issue number but wanted to propose this change to the doc. I can change the number and rebase.

You have the wrong issue number.

@vstinner I made a new issue in that case.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Sep 15, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-09-14-13-40-18.bpo-1635741.o6PrOV.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Sep 15, 2020
eamanu
eamanu approved these changes Sep 16, 2020
View reviewed changes

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Sep 16, 2020
@koubaa
koubaa force-pushed the bpo-1635741-doc branch from 1482eab to 098273f Compare September 16, 2020 00:51
@koubaa

koubaa commented Sep 20, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner is anything else needed before merging this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@koubaa

koubaa commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner bump
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 16, 2020
View reviewed changes
Comment thread Doc/c-api/intro.rst
declared. The sole exception are the type objects; since these must never be
deallocated, they are typically static :c:type:`PyTypeObject` objects.
declared. The sole exception are the type objects; they may be static
:c:type:`PyTypeObject` objects.

@vstinner vstinner Nov 16, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The sole exception are the type objects" looks wrong to me. Almost all types in Python are allocated on the heap.

Only static types are never deallocated.

I'm not sure why these kinds of technical details are giving in an introduction. It would be better to move them to https://docs.python.org/dev/c-api/refcounting.html no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Nov 16, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least, copied there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@shihai1991 shihai1991 Nov 16, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I am not find the docs of PyHeapTypeObject. Maybe add those description info in it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Aug 3, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain what to do with this change. The whole paragraph could be revisited, as Victor hints to. I'm not sure if this change makes things clearer for the reader.

@encukou: thoughts?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@encukou encukou Aug 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be technically correct, it's not just types – PyModuleDef is also a PyObject* (though I assume that's for historical reasons only). But that's too much detail here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KrisThielemans KrisThielemans mentioned this pull request Apr 18, 2022
PyHeapTypeObject errors with PyPy swig/swig#2262
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
encukou
encukou reviewed Aug 4, 2022
View reviewed changes
Comment thread Doc/c-api/intro.rst
Comment on lines +239 to +240
declared. The sole exception are the type objects; they may be static
:c:type:`PyTypeObject` objects.

@encukou encukou Aug 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work?

Suggested change
declared. The sole exception are the type objects; they may be static
:c:type:`PyTypeObject` objects.
declared. (There are a few exceptions, like static type objects, but even those
are usually manipulated via pointers.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
iritkatriel
iritkatriel requested changes Dec 6, 2022
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 6, 2022
@bedevere-bot

bedevere-bot commented Dec 6, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Dec 6, 2022
@koubaa koubaa mannequin mentioned this pull request Jan 12, 2024
C-API documentation ignores heap types and says type objects must never be deallocated #85956
Open
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 8, 2026
@serhiy-storchaka serhiy-storchaka changed the title bpo-41790: update error in documentation gh-85956: update error in documentation Aug 12, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 14, 2026
@ambv

ambv commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This PR is blocked on its author, has not been touched by a human in more than 3 years, and no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on gh-85956.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@encukou encukou encukou left review comments
@shihai1991 shihai1991 shihai1991 left review comments
@erlend-aasland erlend-aasland erlend-aasland left review comments
@iritkatriel iritkatriel iritkatriel requested changes
+1 more reviewer
@eamanu eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@koubaa @vstinner @bedevere-bot @ambv @encukou @iritkatriel @eamanu @shihai1991 @erlend-aasland @the-knights-who-say-ni @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.