GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module (GH-21956) by graingert · Pull Request #22398 · python/cpython

Conversation

@graingert

@graingert graingert commented Sep 24, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

[3.8] bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module (GH-21956)

Closes bpo issue 41602.
(cherry picked from commit a68a2ad)

Co-authored-by: Thomas Grainger [email protected]

https://bugs.python.org/issue41602

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 24, 2020
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Sep 24, 2020
@bedevere-bot bedevere-bot mentioned this pull request Sep 24, 2020
bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module #21956
Merged
@bedevere-bot bedevere-bot added the awaiting review label Sep 24, 2020
@graingert
[3.8] bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pym…
cccc27a 
…ain_run_module (pythonGH-21956)

Closes bpo issue 41602.
(cherry picked from commit a68a2ad)

Co-authored-by: Thomas Grainger <[email protected]>
@graingert
graingert force-pushed the backport-a68a2ad-3.8 branch from d50a77a to cccc27a Compare September 24, 2020 15:12
gvanrossum
gvanrossum approved these changes Sep 24, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the tests pass, what the heck.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv and graingert reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 24, 2020
@ambv
ambv merged commit ae46229 into python:3.8 Sep 24, 2020
@bedevere-bot

bedevere-bot commented Sep 24, 2020

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 24, 2020
@graingert
graingert deleted the backport-a68a2ad-3.8 branch September 24, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@graingert @bedevere-bot @gvanrossum @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.