GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] [doc] Leverage the fact that the actual types can now be indexed for typing (GH-22340) by miss-islington · Pull Request #22430 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

This shows users that they can use the actual types. Using deprecated types is confusing.

This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place.

This should be backported to 3.9.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit d9ab95f)

Co-authored-by: Andre Delfino [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andresdelfino @miss-islington
[doc] Leverage the fact that the actual types can now be indexed for …
1054ec3 
…typing (pythonGH-22340)

This shows users that they can use the actual types. Using deprecated types is confusing.

This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place.

This should be backported to 3.9.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit d9ab95f)

Co-authored-by: Andre Delfino <[email protected]>
@miss-islington
miss-islington requested review from gvanrossum and ilevkivskyi as code owners September 27, 2020 19:07
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 27, 2020
@bedevere-bot bedevere-bot mentioned this pull request Sep 27, 2020
[doc] Leverage the fact that the actual types can now be indexed for typing #22340
Merged
@bedevere-bot bedevere-bot added skip issue skip news docs Documentation in the Doc dir awaiting review labels Sep 27, 2020
@miss-islington

miss-islington commented Sep 27, 2020

Copy link
Copy Markdown
Contributor Author

@andresdelfino: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Sep 27, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And thanks for finding a way to unblock the master PR!)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andresdelfino reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 27, 2020
@miss-islington
miss-islington merged commit bdf46bc into python:3.9 Sep 27, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 27, 2020
@miss-islington
miss-islington deleted the backport-d9ab95f-3.9 branch September 27, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot @andresdelfino
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.