GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-40105: ZipFile truncate in append mode with shorter comment (GH-19337) by miss-islington · Pull Request #22436 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 28, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit ff9147d)

Co-authored-by: Jan Mazur [email protected]

https://bugs.python.org/issue40105

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mzr @miss-islington
bpo-40105: ZipFile truncate in append mode with shorter comment (pyth…
b5420ed 
…onGH-19337)

(cherry picked from commit ff9147d)

Co-authored-by: Jan Mazur <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 28, 2020
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Sep 28, 2020
@bedevere-bot bedevere-bot mentioned this pull request Sep 28, 2020
bpo-40105: Truncating file if opened in append mode. #19337
Merged
@miss-islington

miss-islington commented Sep 28, 2020

Copy link
Copy Markdown
Contributor Author

@mzr and @taleinat: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Sep 28, 2020
taleinat
taleinat approved these changes Sep 28, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 28, 2020
@miss-islington

miss-islington commented Sep 28, 2020

Copy link
Copy Markdown
Contributor Author

@mzr and @taleinat: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@taleinat taleinat closed this Sep 28, 2020
@miss-islington
miss-islington deleted the backport-ff9147d-3.9 branch September 28, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@taleinat taleinat taleinat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @taleinat @the-knights-who-say-ni @bedevere-bot @mzr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.