GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-41939: Fix test_site.test_license_exists_at_url() (GH-22559) by miss-islington · Pull Request #22574 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 6, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Call urllib.request.urlcleanup() to reset the global
urllib.request._opener.
(cherry picked from commit 1fce240)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue41939

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
bpo-41939: Fix test_site.test_license_exists_at_url() (pythonGH-22559)
4ab7ccd 
Call urllib.request.urlcleanup() to reset the global
urllib.request._opener.
(cherry picked from commit 1fce240)

Co-authored-by: Victor Stinner <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 6, 2020
@bedevere-bot bedevere-bot mentioned this pull request Oct 6, 2020
bpo-41939: Fix test_site.test_license_exists_at_url() #22559
Merged
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 6, 2020
@miss-islington

miss-islington commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Oct 6, 2020
@miss-islington

miss-islington commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Oct 6, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 6, 2020
@miss-islington

miss-islington commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 78bddc7 into python:3.8 Oct 6, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 6, 2020
@miss-islington
miss-islington deleted the backport-1fce240-3.8 branch October 6, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.