GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38250: minor Flag refactor by belm0 · Pull Request #22734 · python/cpython

Conversation

@belm0

@belm0 belm0 commented Oct 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Extracted some minor refactoring from a larger work in progress:

  • clarify used return values of _decompose() calls
  • __invert__(): use in-place OR operator, remove unneeded cast

skip news

https://bugs.python.org/issue38250

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@belm0
belm0 requested a review from ethanfurman as a code owner October 17, 2020 01:52
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 17, 2020
@bedevere-bot bedevere-bot added the awaiting review label Oct 17, 2020
auvipy
auvipy suggested changes Oct 17, 2020
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont this need some test adjustment?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Oct 17, 2020
@belm0

belm0 commented Oct 17, 2020

Copy link
Copy Markdown
Contributor Author

dont this need some test adjustment?

no, since there is no change in functionality
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
belm0 added 2 commits November 23, 2020 09:35
@belm0
clarify _decompose() calls
872b06b
@belm0
Flag.__invert__() cleanup
b86aa8e
@belm0
belm0 force-pushed the flag_small_refactor branch from d1a0c1c to b86aa8e Compare November 23, 2020 00:36
@github-actions

github-actions Bot commented Dec 24, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 24, 2020
@ethanfurman

ethanfurman commented Jan 14, 2021

Copy link
Copy Markdown
Member

@belm0 this PR is no longer valid as Flag has been redesigned (using much, if not all, of your input). I would appreciate your feedback on GH-24215.
belm0 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman ethanfurman closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman
1 more reviewer
@auvipy auvipy auvipy requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@belm0 @ethanfurman @auvipy @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.