GeezerVison is showing github.com — [3.9] bpo-42073: allow classmethod to wrap other classmethod-like descriptors. by eriknw · Pull Request #22757 · python/cpython
Conversation
eriknw
commented
Oct 18, 2020
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
bpo-19072 (#8405) allows classmethod to wrap other descriptors, but this does not work when the wrapped descriptor mimics classmethod. The current PR fixes this.
In Python 3.8 and before, one could create a callable descriptor such that this works as expected (see Lib/test/test_decorators.py for examples):
class A:
@myclassmethod
def f1(cls):
return cls
@classmethod
@myclassmethod
def f2(cls):
return cls
In Python 3.8 and before, A.f2() return A. Currently in Python 3.9, it returns type(A). This PR make A.f2() return A again.
As of #8405, classmethod calls obj.__get__(type) if obj has __get__. This allows one to chain @classmethod and @property together. When using classmethod-like descriptors, it's the second argument to __get__--the owner or the type--that is important, but this argument is currently missing. Since it is None, the "owner" argument is assumed to be the type of the first argument, which, in this case, is wrong (we want A, not type(A)).
This PR updates classmethod to call obj.__get__(type, type) if obj has __get__.
This PR is targeting Python 3.9 branch, because I think this is a bug fix. I can also target master (3.10).
I'm not really sure where to add a note of this change.
https://bugs.python.org/issue42073
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bpo-19072 (python#8405) allows `classmethod` to wrap other descriptors, but this does
not work when the wrapped descriptor mimics classmethod. The current PR fixes
this.
In Python 3.8 and before, one could create a callable descriptor such that this
works as expected (see Lib/test/test_decorators.py for examples):
```python
class A:
@myclassmethod
def f1(cls):
return cls
@classmethod
@myclassmethod
def f2(cls):
return cls
```
In Python 3.8 and before, `A.f2()` return `A`. Currently in Python 3.9, it
returns `type(A)`. This PR make `A.f2()` return `A` again.
As of python#8405, classmethod calls `obj.__get__(type)` if `obj` has `__get__`.
This allows one to chain `@classmethod` and `@property` together. When
using classmethod-like descriptors, it's the second argument to `__get__`--the
owner or the type--that is important, but this argument is currently missing.
Since it is None, the "owner" argument is assumed to be the type of the first
argument, which, in this case, is wrong (we want `A`, not `type(A)`).
This PR updates classmethod to call `obj.__get__(type, type)` if `obj` has
`__get__`.
eriknw
changed the title
bpo-42073: allow classmethod to wrap other classmethod-like descriptors.
[3.9] bpo-42073: allow classmethod to wrap other classmethod-like descriptors.
Oct 18, 2020
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ambv
requested review from
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
ethanfurman,
gpshead,
gvanrossum,
ilevkivskyi,
isidentical,
lysnikolaou,
markshannon,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
terryjreedy and
tiran
as code owners
July 13, 2021 14:52
|
Oops, changing the base of the pull request didn't do what I thought it would and reverting back to 3.9 leaves the mess as is. I'll recreate this pull request on main from scratch.
|
encukou reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|