GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-26131: deprecate the use of load_module() by brettcannon · Pull Request #22905 · python/cpython

Conversation

@brettcannon

@brettcannon brettcannon commented Oct 23, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Deprecating the use of load_module() requires two parts:

  1. The actual load_module() implementations are deprecated.
  2. Use of load_module() as a fallback for exec_module() trigger an ImportWarning.

This makes sure that either direct use of the method or indirect use by the import system raises some warning.

The method itself has been documented as deprecated since Python 3.6 and has been superceded by exec_module().

https://bugs.python.org/issue26131

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brettcannon
bpo-26131: deprecate the use of load_module()
4c7284c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 23, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Oct 23, 2020
@brettcannon
brettcannon requested review from encukou, ericsnowcurrently and warsaw October 23, 2020 00:36
warsaw
warsaw requested changes Oct 23, 2020
View reviewed changes

@warsaw warsaw left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. There are also test failures.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/importlib/_bootstrap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 23, 2020
@bedevere-bot

bedevere-bot commented Oct 23, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Oct 23, 2020
@brettcannon
Fix a grammatical error in a comment
f05002b
@brettcannon

brettcannon commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Oct 23, 2020
@bedevere-bot

bedevere-bot commented Oct 23, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from warsaw October 23, 2020 18:14
brettcannon added 2 commits October 27, 2020 14:37
@brettcannon
Merge branch 'master' into deprecate-load_module
0c09542
@brettcannon
Update to print out the loader's name in the ImportWarning
57f6a12
@brettcannon

brettcannon commented Oct 28, 2020

Copy link
Copy Markdown
Member Author

This is going to require implementing exec_module() for zipimport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon closed this Oct 28, 2020
@brettcannon brettcannon mentioned this pull request Nov 7, 2020
bpo-42131: Add PEP 451-related methods to zipimport #23187
Merged
@brettcannon brettcannon mentioned this pull request Nov 22, 2020
gh-70319: Deprecate usage of load_module() #23469
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@encukou encukou Awaiting requested review from encukou
@warsaw warsaw Awaiting requested review from warsaw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brettcannon @bedevere-bot @warsaw @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.