GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42197: Disable automatic update of frame locals during tracing by fabioz · Pull Request #23028 · python/cpython

Conversation

@fabioz

@fabioz fabioz commented Oct 29, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This pull request removes the calls to PyFrame_FastToLocalsWithError and PyFrame_LocalsToFast inside the tracing.

https://bugs.python.org/issue42197

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 29, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@fabioz

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Oct 29, 2020
@bedevere-bot bedevere-bot added the awaiting review label Oct 29, 2020
@fabioz
fabioz force-pushed the issue42197 branch 2 times, most recently from 6148136 to 4c5f56e Compare October 29, 2020 16:00
vstinner
vstinner reviewed Oct 29, 2020
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@fabioz
fabioz force-pushed the issue42197 branch from 4c5f56e to 9a84fb5 Compare December 20, 2020 10:41
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Dec 20, 2020
@fabioz

fabioz commented Dec 20, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner updated docs with requested changes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fabioz
bpo-42197: Disable automatic update of frame locals during profiling …
50fe523
…and tracing
@fabioz
fabioz force-pushed the issue42197 branch from 9a84fb5 to 50fe523 Compare December 20, 2020 11:20
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 21, 2020
@vstinner

vstinner commented Jan 20, 2021

Copy link
Copy Markdown
Member

cc @markshannon @ncoghlan

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Jan 21, 2022

Copy link
Copy Markdown
Member

@fabioz could you update this for 3.11?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Feb 5, 2022

Copy link
Copy Markdown
Member

@fabioz If you don't have time to do this, just say and I'll put together a new PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fabioz

fabioz commented Feb 5, 2022

Copy link
Copy Markdown
Contributor Author

@fabioz If you don't have time to do this, just say and I'll put together a new PR.

Hello @markshannon I really have my hands full right now, so, if you can put together a new PR that'd be great.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Mar 22, 2022

Copy link
Copy Markdown
Member

New PR is #32055

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon markshannon closed this Mar 22, 2022
@fabioz fabioz mannequin mentioned this pull request Apr 10, 2022
Disable automatic update of frame locals during tracing #86363
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@fabioz @the-knights-who-say-ni @vstinner @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.