GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-42218: Correctly handle errors in left-recursive rules (GH-23065) by lysnikolaou · Pull Request #23066 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented Oct 31, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Left-recursive rules need to check for errors explicitly, since
even if the rule returns NULL, the parsing might continue and lead
to long-distance failures.

Co-authored-by: Pablo Galindo [email protected]
(cherry picked from commit 02cdfc9)

https://bugs.python.org/issue42218

Automerge-Triggered-By: GH:lysnikolaou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou @pablogsal
[3.9] bpo-42218: Correctly handle errors in left-recursive rules (pyt…
0817e5d 
…honGH-23065)

Left-recursive rules need to check for errors explicitly, since
even if the rule returns NULL, the parsing might continue and lead
to long-distance failures.

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 02cdfc9)
@lysnikolaou
lysnikolaou requested a review from pablogsal as a code owner October 31, 2020 18:37
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 31, 2020
@bedevere-bot bedevere-bot mentioned this pull request Oct 31, 2020
bpo-42218: Correctly handle errors in left-recursive rules #23065
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Oct 31, 2020
pablogsal
pablogsal approved these changes Oct 31, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 31, 2020
@lysnikolaou lysnikolaou added the 🤖 automerge label Oct 31, 2020
@miss-islington

miss-islington commented Oct 31, 2020

Copy link
Copy Markdown
Contributor

@lysnikolaou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit cfcb952 into python:3.9 Oct 31, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 31, 2020
@lysnikolaou
lysnikolaou deleted the backport-02cdfc9-3.9 branch October 31, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@lysnikolaou @miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.