GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103092: Prep curses module for multi-phase init by koubaa · Pull Request #23091 · python/cpython

Conversation

@koubaa

@koubaa koubaa commented Nov 2, 2020 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue1635741

  • Issue: Isolate Stdlib Extension Modules #103092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 2, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 2, 2020
shihai1991
shihai1991 reviewed Nov 2, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 reviewed Nov 2, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 reviewed Nov 2, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Nov 2, 2020

Copy link
Copy Markdown
Member

cc @vstinner @corona10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@koubaa
koubaa marked this pull request as draft November 3, 2020 00:31
@koubaa
koubaa marked this pull request as ready for review November 4, 2020 02:37
@koubaa

koubaa commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @corona10 @shihai1991 please review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 4, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
koubaa added 3 commits February 28, 2021 12:30
@koubaa
Prep curses module for multi-phase init
ab3c3f3
@koubaa
fix issues with CI
ddfb744
@koubaa
remove PyImport_ImportModuleNoBlock
0dc705b
@koubaa
koubaa force-pushed the bpo-1635741-curses-prep branch from c96930b to 0dc705b Compare February 28, 2021 18:31
@koubaa

koubaa commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner would you please review?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Mar 11, 2021
View reviewed changes
Comment thread Modules/_cursesmodule.c
} \
if (PyDict_SetItemString(d, string, o) < 0) { \
Py_DECREF(o); \
goto error; \

@vstinner vstinner Mar 11, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"return NULL;" is enough: you should remove the error label. An error label is used when you need to clean up things, it's not the case here. Same remark at the bottom of the file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_cursesmodule.c
return NULL;
}

static void *PyCurses_API[PyCurses_API_pointers];

@vstinner vstinner Mar 11, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are warnings on the PR, like ‘PyCurses_API’ defined but not used [-Wunused-variable].

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel

iritkatriel commented Apr 11, 2022

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741 is closed. What is the status of this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 19, 2022

Copy link
Copy Markdown
Member

The change is still relevant, but should use a new issue number.

Moreover, the SC asked to put the conversion of static types to heap types on hold. @encukou and @erlend-aasland wrote https://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

FYI, PEP-687 was just accepted.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
@encukou encukou changed the title bpo-1635741: Prep curses module for multi-phase init gh-103092: Prep curses module for multi-phase init Mar 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 28, 2024
Isolate Stdlib Extension Modules #103092
Closed
24 of 25 tasks
@erlend-aasland

erlend-aasland commented May 8, 2024

Copy link
Copy Markdown
Contributor

Closing as per #101714 (comment). Thanks for the effort, Mohamed!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@shihai1991 shihai1991 shihai1991 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@koubaa @shihai1991 @iritkatriel @vstinner @erlend-aasland @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.