GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-42207 :Disable peg generator tests when building with PGO (GH-23141) by miss-islington · Pull Request #23155 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 4, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.
(cherry picked from commit 100964e)

Co-authored-by: serge-sans-paille [email protected]

https://bugs.python.org/issue42207

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serge-sans-paille @miss-islington
Disable peg generator tests when building with PGO (pythonGH-23141)
099bc40 
Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.
(cherry picked from commit 100964e)

Co-authored-by: serge-sans-paille <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners November 4, 2020 23:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 4, 2020
@bedevere-bot bedevere-bot mentioned this pull request Nov 4, 2020
bpo-42207: Disable peg generator tests when building with PGO #23141
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir awaiting review labels Nov 4, 2020
@miss-islington

miss-islington commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

@serge-sans-paille and @pablogsal: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

@serge-sans-paille and @pablogsal: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Nov 4, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 4, 2020
@pablogsal pablogsal changed the title [3.9] Disable peg generator tests when building with PGO (GH-23141) [3.9] bpo-42207:Disable peg generator tests when building with PGO (GH-23141) Nov 4, 2020
@pablogsal pablogsal changed the title [3.9] bpo-42207:Disable peg generator tests when building with PGO (GH-23141) [3.9] bpo-42207 :Disable peg generator tests when building with PGO (GH-23141) Nov 4, 2020
@miss-islington

miss-islington commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

@serge-sans-paille and @pablogsal: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 3997a4e into python:3.9 Nov 4, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 4, 2020
@miss-islington
miss-islington deleted the backport-100964e-3.9 branch November 4, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot @serge-sans-paille
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.