GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41987: Fix unnecessary evaluation of return type forward declaratons in singledispatch. by mental32 · Pull Request #23216 · python/cpython

Conversation

@mental32

@mental32 mental32 commented Nov 10, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I know that interest was expressed in the bpo thread about finding the root cause of this issue sadly I have not been able to figure that out yet, instead I offer a patch 😅

https://bugs.python.org/issue41987

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mental32
bpo-41987: Fix unnecessary evaluation of return type forward declarat…
f496841 
…ions in singledispatch.
@mental32
mental32 requested a review from rhettinger as a code owner November 10, 2020 06:08
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 10, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 10, 2020
gvanrossum
gvanrossum reviewed Nov 11, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m also still very interested in the root cause.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/functools.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mental32
bpo-41987: remove unnecessary 3.9.x version check.
6b17dee
@mental32

mental32 commented Nov 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@gvanrossum thank you for the review!

I've applied and committed the suggested changes, and will be investigating the regression further when I can.

At the moment I am only comparing diffs of tag 3.8 and tag 3.9 for file /Lib/typing.py since I suspect the regression will be visible there. If I can't eyeball it I'll start bisecting commits from 3.8 to master's head testing for reproducibility.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hongweipeng

hongweipeng commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

I think the reason is that ForwardRef._evaluate() did two evaluations or the recursive check failed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@mental32 mental32 closed this Sep 19, 2021
@glyph glyph mannequin mentioned this pull request Apr 10, 2022
singledispatchmethod raises an error when relying on a forward declaration #86153
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mental32 @hongweipeng @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.