GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42327: Add PyModule_Add(). by serhiy-storchaka · Pull Request #23240 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 11, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue42327

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 11, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Nov 11, 2020
@serhiy-storchaka
bpo-42327: Add PyModule_Add().
3387f58
@serhiy-storchaka
serhiy-storchaka force-pushed the pymodule-add branch from 67e94c9 to 3387f58 Compare November 11, 2020 20:38
@serhiy-storchaka serhiy-storchaka changed the title Add PyModule_Add(). bpo-42327: Add PyModule_Add(). Nov 11, 2020
serhiy-storchaka added 3 commits November 12, 2020 10:53
@serhiy-storchaka
Fix more leaks.
9bfe0e7
@serhiy-storchaka
Fix typo.
76b6063
@serhiy-storchaka
Merge branch 'master' into pymodule-add
17279ae
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review November 14, 2020 17:47
@serhiy-storchaka
serhiy-storchaka requested review from a team, abalkin, pablogsal, pganssle, rhettinger and tiran as code owners November 14, 2020 17:47
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 14, 2020
@bedevere-bot

bedevere-bot commented Nov 14, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 17279ae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 14, 2020
serhiy-storchaka added 5 commits November 14, 2020 21:23
@serhiy-storchaka
Simplify ossaudiodev.c
a18ba19
@serhiy-storchaka
Fix possible leaks in _ssl.
105c29d
@serhiy-storchaka
Fix possible leaks in _testbuffer
edfc827
@serhiy-storchaka
Fix possible leaks in select
db2bec0
@serhiy-storchaka
Fix possible leaks in socket
a28ecbc
tiran
tiran suggested changes Nov 14, 2020
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move your changes of _ssl.c to another PR? This PR will cause major conflicts with two of my PRs.

I also like to get your opinion on https://discuss.python.org/t/define-module-constants-in-pymoduledef/5749 . I have suggested a radically different approach for module constant initialization that is even more convenient than PyModule_Add().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 14, 2020
@bedevere-bot

bedevere-bot commented Nov 14, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Nov 14, 2020
@serhiy-storchaka

serhiy-storchaka commented Nov 14, 2020

Copy link
Copy Markdown
Member Author

I will most likely break this PR into several parts and merge them separately. It grew more than I expected because for each modified module I fixed all potential leaks, and some module expose many constants.
tiran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added 2 commits November 15, 2020 14:32
@serhiy-storchaka
Fix possible leaks in _elementtree
ca9f696
@serhiy-storchaka
Fix possible leaks in xxlimited
7014f96
@serhiy-storchaka
Merge branch 'master' into pymodule-add
981b580
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 21, 2020
bpo-42327: Add PyModule_Add() (smaller). #23443
Merged
@serhiy-storchaka

serhiy-storchaka commented Nov 21, 2020

Copy link
Copy Markdown
Member Author

Created #23443 which does not include large changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added the DO-NOT-MERGE label Nov 21, 2020
@github-actions

github-actions Bot commented Dec 22, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 22, 2020
@rhettinger
rhettinger removed their request for review May 3, 2022 06:14
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 15, 2022
C API: Add PyModule_Add() function #86493
Closed
@serhiy-storchaka

serhiy-storchaka commented Jul 18, 2023

Copy link
Copy Markdown
Member Author

Split and merged as a number of smaller PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Jul 18, 2023
@serhiy-storchaka
serhiy-storchaka deleted the pymodule-add branch July 1, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abalkin abalkin Awaiting requested review from abalkin
@pablogsal pablogsal Awaiting requested review from pablogsal
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
1 more reviewer
@tiran tiran tiran requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@serhiy-storchaka @bedevere-bot @tiran @pablogsal @the-knights-who-say-ni @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.