GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42330: Registered browsh in webbrowser module by Yash-Singh1 · Pull Request #23289 · python/cpython

Conversation

@Yash-Singh1

@Yash-Singh1 Yash-Singh1 commented Nov 14, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Summary

Registered in browsh inside webbrowser module

Overview

Browsh is a terminal-based browser that runs based on headless firefox. Here is the documentation link for more: https://www.brow.sh/

The webbrowser module is:

Interfaces for launching and remotely controlling Web browsers.

According to a comment at the top of the file.
They have many default registered terminal browsers including lynx and w3m. This PR adds on to that list by adding in the browsh browser using the startup-url flag:

--startup-url string URL to launch at startup (default "https://www.brow.sh")

I also added in browsh inside the Docs for webbrowser

Links

The link to the issue: https://bugs.python.org/issue42330
The link to the webbrowser documentation: https://docs.python.org/3/library/webbrowser.html
The browsh documentation: https://www.brow.sh/
The Github Repo for Browsh: https://github.com/browsh-org/browsh

https://bugs.python.org/issue42330

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Yash-Singh1 added 2 commits November 13, 2020 17:20
@Yash-Singh1
Added in browsh as a registered webbrowser
81c4a36
@Yash-Singh1
Added browsh into webbrowser docs
d75cb39
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 14, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Yash-Singh1

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Nov 14, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 14, 2020
@terryjreedy

terryjreedy commented Nov 14, 2020

Copy link
Copy Markdown
Member

Sorry, we are not going to add this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy closed this Nov 14, 2020
@Yash-Singh1
Yash-Singh1 deleted the patch-1 branch November 15, 2020 00:12
@saiansh2525 saiansh2525 mannequin mentioned this pull request Apr 10, 2022
Add browsh in the webbrowser module #86496
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Yash-Singh1 @the-knights-who-say-ni @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.