GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-42345: Fix three issues with typing.Literal parameters (GH-23294) by uriyyo · Pull Request #23335 · python/cpython

Conversation

@uriyyo

@uriyyo uriyyo commented Nov 17, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Literal equality no longer depends on the order of arguments.

Fix issue related to typing.Literal caching by adding typed parameter to typing._tp_cache function.

Add deduplication of typing.Literal arguments.

(cherry picked from commit f03d318)

Co-authored-by: Yurii Karabas [email protected]

https://bugs.python.org/issue42345

Automerge-Triggered-By: GH:gvanrossum

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@uriyyo
[3.9] bpo-42345: Fix three issues with typing.Literal parameters (pyt…
2850084 
…honGH-23294)

Literal equality no longer depends on the order of arguments.

Fix issue related to `typing.Literal` caching by adding `typed` parameter to `typing._tp_cache` function.

Add deduplication of `typing.Literal` arguments..
(cherry picked from commit f03d318)

Co-authored-by: Yurii Karabas <[email protected]>
@uriyyo
uriyyo requested review from gvanrossum and ilevkivskyi as code owners November 17, 2020 07:52
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 17, 2020
@bedevere-bot bedevere-bot mentioned this pull request Nov 17, 2020
bpo-42345: Fix three issues with typing.Literal parameters #23294
Merged
@bedevere-bot bedevere-bot added the awaiting review label Nov 17, 2020
gvanrossum
gvanrossum approved these changes Nov 17, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 17, 2020
@gvanrossum gvanrossum added the 🤖 automerge label Nov 17, 2020
@miss-islington
miss-islington merged commit ac472b3 into python:3.9 Nov 17, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 17, 2020
@Fatal1ty Fatal1ty mentioned this pull request Apr 19, 2023
typing.Literal isn't supported properly on Python 3.9.0 Fatal1ty/mashumaro#103
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@uriyyo @gvanrossum @the-knights-who-say-ni @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.