GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-42345: Fix hash implementation of typing.Literal (GH-23383) by miss-islington · Pull Request #23408 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 19, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix hash implementation of typing.Literal.

Update docs regarding typing.Litaral caching.

Base implementation was done in PR GH-23294.
(cherry picked from commit 1b54077)

Co-authored-by: Yurii Karabas [email protected]

https://bugs.python.org/issue42345

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@uriyyo @miss-islington
bpo-42345: Fix hash implementation of typing.Literal (pythonGH-23383)
15eb339 
Fix hash implementation of `typing.Literal`.

Update docs regarding `typing.Litaral` caching.

Base implementation was done in PR pythonGH-23294.
(cherry picked from commit 1b54077)

Co-authored-by: Yurii Karabas <[email protected]>
@miss-islington
miss-islington requested review from gvanrossum and ilevkivskyi as code owners November 19, 2020 16:17
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 19, 2020
@bedevere-bot bedevere-bot mentioned this pull request Nov 19, 2020
bpo-42345: Fix hash implementation of typing.Literal #23383
Merged
@bedevere-bot bedevere-bot added the skip news label Nov 19, 2020
@miss-islington

miss-islington commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

@uriyyo: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Nov 19, 2020
@miss-islington

miss-islington commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

@uriyyo: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Nov 19, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 19, 2020
@miss-islington

miss-islington commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

@uriyyo: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 2acd9d0 into python:3.9 Nov 19, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 19, 2020
@miss-islington
miss-islington deleted the backport-1b54077-3.9 branch November 19, 2020 16:51
@miss-islington

miss-islington commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

@uriyyo: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot @uriyyo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.