GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30459: Convert PyTuple_SET_ITEM() to a function by vstinner · Pull Request #23645 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 4, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Convert the PyTuple_SET_ITEM(), PyList_SET_ITEM() and PyCell_SET()
macros to static inline functions.

https://bugs.python.org/issue30459

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tryalice reacted with thumbs up emoji tryalice reacted with confused emoji
All reactions
  • 👍 1 reaction
  • 😕 1 reaction
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 4, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 4, 2020
@vstinner

vstinner commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

cc @ZackerySpytz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Dec 4, 2020
bpo-30459: Cast the result of PyList_SET_ITEM() to void #19975
Merged
@vstinner
bpo-30459: Convert PyTuple_SET_ITEM() to a function
0194612 
Convert the PyTuple_SET_ITEM(), PyList_SET_ITEM() and PyCell_SET()
macros to static inline functions.
@vstinner

vstinner commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

PR updated to convert also PyCell_SET().
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Add a note in What's New in Python 3.10
9309a59
@vstinner

vstinner commented Dec 5, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka prefers PR #19975, so I close my PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Dec 5, 2020
@vstinner
vstinner deleted the set_item_func branch December 5, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.