GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-42532: Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function (GH-23613) by tirkarthi · Pull Request #23676 · python/cpython

Conversation

@tirkarthi

@tirkarthi tirkarthi commented Dec 7, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Check if NonCallableMock's spec_arg is not None instead of call its bool function
(cherry picked from commit c598a04)

Co-authored-by: idanw206 [email protected]

https://bugs.python.org/issue42532

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@idanw206 @tirkarthi
[3.9] bpo-42532: Check if NonCallableMock's spec_arg is not None inst…
fe60d60 
…ead of call its __bool__ function (GH23613)

Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function
(cherry picked from commit c598a04)

Co-authored-by: idanw206 <[email protected]>
@tirkarthi
tirkarthi requested a review from cjw296 December 7, 2020 12:50
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 7, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 7, 2020
cjw296
cjw296 approved these changes Dec 7, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 7, 2020
@idanw206

idanw206 commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

Thanks for the backport! Looking forward for this to be released!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@idanw206

idanw206 commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

@tirkarthi @cjw296 Can one of you guys merge it? Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi
tirkarthi merged commit 14f2a12 into python:3.9 Dec 14, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 14, 2020
@tirkarthi
tirkarthi deleted the backport-c598a04-3.9 branch December 14, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjw296 cjw296 cjw296 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tirkarthi @idanw206 @cjw296 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.