GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-86819: Add ISO-TP CAN socket constants by rumpelsepp · Pull Request #23794 · python/cpython

Conversation

@rumpelsepp

@rumpelsepp rumpelsepp commented Dec 16, 2020 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adds constants to the socket module which are provided by the new isotp module available in Linux >= 5.10.

https://bugs.python.org/issue42653
#86819

  • Issue: Expose ISO-TP Contants for Linux >= 5.10 #86819

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Dec 16, 2020
@the-knights-who-say-ni

the-knights-who-say-ni commented Dec 16, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rumpelsepp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Dec 16, 2020
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Dec 16, 2020
@shawnl

shawnl commented Dec 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

As the reporter or the original feature request this patch looks good to me.

(Although I hate autoconf magic)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rumpelsepp

rumpelsepp commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

(Although I hate autoconf magic)

As do I… Is there anything else I have to adjust here? My autoreconf version seems different and it mutilates the checked in configure script.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 16, 2020

Copy link
Copy Markdown
Member

Please open a new issue: https://bugs.python.org/issue10141 is closed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rumpelsepp rumpelsepp changed the title bpo-10141: Add constants for isotp.h which is included in Linux >= 5.10 issue42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020
@rumpelsepp rumpelsepp changed the title issue42653: Add constants for isotp.h which is included in Linux >= 5.10 bpo-42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020
@rumpelsepp

rumpelsepp commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran
tiran previously requested changes Dec 16, 2020
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a blurb and leave the CAN_ISOTP macro in place.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/socketmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 16, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Dec 16, 2020
@rumpelsepp
rumpelsepp force-pushed the isotp branch from 356d24d to 82ad5d7 Compare December 16, 2020 09:30
@rumpelsepp

rumpelsepp commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Dec 16, 2020
@bedevere-bot

bedevere-bot commented Dec 16, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from tiran December 16, 2020 09:30
@github-actions

github-actions Bot commented Jan 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@tiran
tiran removed their request for review April 17, 2021 21:16
@rumpelsepp

rumpelsepp commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

Am I supposed to do any more changes here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost mentioned this pull request May 19, 2021
bpo-42653: Add constants to socket module for IsoTp CAN protocol #26174
Closed
@rumpelsepp
rumpelsepp force-pushed the isotp branch 4 times, most recently from c287165 to 0c4ed7d Compare February 28, 2022 23:47
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Oct 14, 2024
@erlend-aasland
erlend-aasland dismissed tiran’s stale review October 14, 2024 22:12

Christian's concerns were addressed: a NEWS blurb was added, and the CAN_ISOTP macro was left in place.

@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024
@bedevere-bot

bedevere-bot commented Oct 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ffae37c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024
@picnixz

picnixz commented Aug 22, 2025

Copy link
Copy Markdown
Member

Could you move the what's new entry to 3.15.rst instead?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rumpelsepp
rumpelsepp force-pushed the isotp branch from ffae37c to 155423e Compare August 22, 2025 09:48
@rumpelsepp
rumpelsepp requested a review from AA-Turner as a code owner August 22, 2025 09:48
@picnixz

picnixz commented Aug 22, 2025

Copy link
Copy Markdown
Member

Don't forget to re-add the NEWS entry (I don't know where it disppeared)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rumpelsepp
rumpelsepp force-pushed the isotp branch from f4175fa to cd8ee0d Compare August 22, 2025 09:52
@rumpelsepp

rumpelsepp commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

Your comments should be addressed now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Aug 22, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Aug 22, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Aug 22, 2025
View reviewed changes
Comment thread Lib/test/test_socket.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2025-08-22-09-53-45.gh-issue-86819.ECxvwx.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rumpelsepp
rumpelsepp force-pushed the isotp branch 3 times, most recently from 3508d7e to 7fb109b Compare August 22, 2025 10:02
Patrick Menschel and others added 2 commits August 22, 2025 12:03
Patrick Menschel @rumpelsepp
Add constants to socket module for ISO-TP CAN protocol
f3837ad 
Co-authored-by: Stefan Tatschner <[email protected]>
@rumpelsepp
Run ./Tools/build/regen-configure.sh
d4e2960
@rumpelsepp
rumpelsepp force-pushed the isotp branch from 7fb109b to d4e2960 Compare August 22, 2025 10:03
@rumpelsepp

rumpelsepp commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz Thank you for your review. I think I have catched up with your remarks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz approved these changes Aug 22, 2025
View reviewed changes
@erlend-aasland
Merge branch 'main' into isotp
da06e89
@erlend-aasland
erlend-aasland requested a review from emmatyping as a code owner September 17, 2025 16:52
@erlend-aasland
erlend-aasland enabled auto-merge (squash) September 17, 2025 16:54
@erlend-aasland erlend-aasland linked an issue Sep 17, 2025 that may be closed by this pull request
Expose ISO-TP Contants for Linux >= 5.10 #86819
Closed
@erlend-aasland
erlend-aasland merged commit a9b6b09 into python:main Sep 17, 2025
@rumpelsepp rumpelsepp mannequin mentioned this pull request Apr 10, 2022
Expose ISO-TP Contants for Linux >= 5.10 #86819
Closed
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@tiran tiran Awaiting requested review from tiran
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose ISO-TP Contants for Linux >= 5.10

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@rumpelsepp @the-knights-who-say-ni @shawnl @vstinner @bedevere-bot @picnixz @tiran @erlend-aasland @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.