GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42843: Doc: Bump Sphinx min-version (needed as we use :no-trim-doctest-flags:). by JulienPalard · Pull Request #24142 · python/cpython

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Jan 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Bump min sphinx version (thanks @asottile noticing in #23620 (comment))

This needs no backport, but please don't merge until there's a concensus on b.p.o.

https://bugs.python.org/issue42843

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JulienPalard
Doc: Bump Sphinx min-version (needed as we use :no-trim-doctest-flags:).
1f8f1ed
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 6, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jan 6, 2021
@JulienPalard JulienPalard added skip issue skip news and removed awaiting core review labels Jan 6, 2021
@asottile

asottile commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

CC @mcepl @pablogsal re: b63a620

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard JulienPalard added the DO-NOT-MERGE label Jan 6, 2021
@JulienPalard JulienPalard changed the title Doc: Bump Sphinx min-version (needed as we use :no-trim-doctest-flags:). bpo-42843: Doc: Bump Sphinx min-version (needed as we use :no-trim-doctest-flags:). Jan 6, 2021
@mcepl

mcepl commented Jan 7, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What can I say? It is a bad idea: why do we want to eliminate more platforms from being able to build Python? Yes, of course, we Linux enterprise distributors will again patch that nonsense away, but it is just making our life more difficult.

Also, this is one more proof (as if we need more of them) that doctests are bad idea. They could be useful for some very limited areas of testing, but they are so limited that their authors are now trying again to sneak in yeat another one-purpose programming language in commentaries to overcome their deficiencies.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jan 7, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

What can I say? It is a bad idea: why do we want to eliminate more platforms from being able to build Python? Yes, of course, we Linux enterprise distributors will again patch that nonsense away, but it is just making our life more difficult.

Also, this is one more proof (as if we need more of them) that doctests are bad idea. They could be useful for some very limited areas of testing, but they are so limited that their authors are now trying again to sneak in yeat another one-purpose programming language in commentaries to overcome their deficiencies.

Thanks a lot, @mcepl for expressing your concerns regarding this change. I assure you that no one is trying to make life more difficult for anyone so please, avoid referring to patches as "nonsense" or mentioning that "authors are now trying again to sneak in yeat another one-purpose programming language in commentaries to overcome their deficiencies" although I agree with some of your concerns, there may be people that disagree with those statements and there is no need to express them in an aggressive way. Thanks for your understanding.

merwok, willingc, and AlexWaygood reacted with thumbs up emoji vstinner reacted with heart emoji
All reactions
  • 👍 3 reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcepl

mcepl commented Jan 7, 2021

Copy link
Copy Markdown
Contributor

Thanks a lot, @mcepl for expressing your concerns regarding this change. I assure you that no one is trying to make life more difficult for anyone so please, avoid referring to patches as "nonsense" or mentioning that "authors are now trying again to sneak in yeat another one-purpose programming language in commentaries to overcome their deficiencies" although I agree with some of your concerns, there may be people that disagree with those statements and there is no need to express them in an aggressive way. Thanks for your understanding.

Thank you for being my PC police officer today, but I don't think your help is really needed here. Anybody who would at least try to understand what I was writing about, would understand that by “sneaking” I don’t mean anything morally wrong, but the tendency of all those ”simple solutions” to survive and try to claim to be simple, while they are forced by the evil world to be anything but that. So, we have originally simple JSON (”which shows whole XML world with its schemas, validators etc. how stupid they are, when the document transfer can be simple” and now we have schemas and validators for JSON as well), or yet-another-replacement-for-autotools-which-claims-to-be-simple (cmake, scons, ninja, meson, waf!) which turns later into horrible monster quite similar to autotools. It seems to me doctests are following exactly the very same trajectory, and sacrificing portability to older platforms for their sake seems to me like a quite bad deal.

merwok reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcepl

mcepl commented Jan 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

OK, after discussion with @vstinner … if we are talking only about Python 3.10+, then I am probably really silly. Sphinx 3.2 it is.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard

JulienPalard commented Jan 12, 2021

Copy link
Copy Markdown
Member Author

Let's make it clear: this PR should not be backported, it's for Python 3.10 only.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@asottile

asottile commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

alrighty, given that I'm going to stop distributing the docs with deadsnakes

the aggressive deprecation of ~6 month old sphinx versions makes it impossible to keep building cleanly even for the latest LTS release of ubuntu 20.04, I have no hope of docs building successfully on 18.04 or 16.04

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard

JulienPalard commented Jan 12, 2021

Copy link
Copy Markdown
Member Author

the aggressive deprecation

Please note this PR is marked as DO-NOT-MERGE, I'm trying to gather as much feedback as possible, I'm not sneaking this PR without conversation, and I'm open to hear that it's not possible.

While you're here I'd be happy to learn something: why relying on packaged Sphinx to build the doc, instead of a Sphinx in a venv like the Docs/Makefile does?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@asottile

asottile commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

the aggressive deprecation

Please note this PR is marked as DO-NOT-MERGE, I'm trying to gather as much feedback as possible, I'm not sneaking this PR without conversation, and I'm open to hear that it's not possible.

While you're here I'd be happy to learn something: why relying on packaged Sphinx to build the doc, instead of a Sphinx in a venv like the Docs/Makefile does?

diverging from debian upstream creates more maintenance burden

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard JulienPalard mentioned this pull request Jan 21, 2021
bpo-42843: Keep Sphinx 1.8 and Sphinx 2 compatibility #24282
Merged
@JulienPalard

JulienPalard commented Jan 21, 2021

Copy link
Copy Markdown
Member Author

I'm opening #24282 to keep Sphinx 2 compat for a few more releases.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard JulienPalard closed this Jan 21, 2021
@JulienPalard
JulienPalard deleted the mdk/bump-needs-sphinx branch October 9, 2021 07:14
@sorcio sorcio mentioned this pull request May 8, 2022
gh-80856: doc: reveal doctest directives #92318
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

DO-NOT-MERGE skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JulienPalard @asottile @mcepl @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.