GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Convert zoneinfo type to heap type by erlend-aasland · Pull Request #24481 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 8, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-40077: Convert zoneinfo type to heap type
073a712
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 8, 2021
@bedevere-bot bedevere-bot added the awaiting review label Feb 8, 2021
@erlend-aasland

erlend-aasland commented Feb 8, 2021

Copy link
Copy Markdown
Contributor Author

cc. @corona10 @vstinner

FYI: _zoneinfo is already multi-phase init.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Add NEWS
fda85d2
@pablogsal

pablogsal commented Feb 8, 2021

Copy link
Copy Markdown
Member

I would recommend waiting for #24065 (comment) before continuing with heap type changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 8, 2021

Copy link
Copy Markdown
Contributor Author

I would recommend waiting for #24065 (comment) before continuing with heap type changes

No problem :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 reviewed Feb 8, 2021
View reviewed changes
Comment thread Modules/_zoneinfo.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_zoneinfo.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland added 2 commits February 8, 2021 19:56
Erlend E. Aasland
Address review: fix ref.leak
19df6f9
Erlend E. Aasland
Address review: remove commented out module doc
39f21be
@github-actions

github-actions Bot commented Mar 11, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 11, 2021
@erlend-aasland erlend-aasland closed this Mar 19, 2021
@erlend-aasland

erlend-aasland commented Oct 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I would recommend waiting for #24065 (comment) before continuing with heap type changes

BTW, I just skimmed through PEP 630 Isolating Extension Modules again, and I started wondering why it is not enough? It is well written, accepted/active, and it explains the rationale of heap types well, and it even advocates that the standard library should be an "early adopter". Has there been an official statement from the SC regarding halting bpo-40077? Just wondering :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

FYI, PEP-687 was just accepted.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihai1991 shihai1991 shihai1991 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @pablogsal @shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.