GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update handlers.py to have a configurable message_separator_character by reahaas · Pull Request #24556 · python/cpython

Conversation

reahaas commented Feb 17, 2021

Copy link

Copy Markdown

SyslogHandler, emit function add the nul_character to the message. This PR allows the user to choose what character to use to separate messages.
The functionality of append_nul that was a boolean variable stays the same since the user can override this value since it's a class attribute:
From the docs:

To enable easier handling of Syslog messages in the face of all these differing daemon behaviours, the appending of the NUL byte has been made configurable, through the use of a class-level attribute, append_nul. This defaults to True (preserving the existing behaviour) but can be set to False on a SysLogHandler instance in order for that instance to not append the NUL terminator.

So now this functionality is possible through setting:

message_separator_character = ''  # using the empty string
# instead of doing:
# append_nul = False

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update handlers.py

7c8b63f

SyslogHandler, emit function add the nul_character to the message. This PR allows the user to choose what character to use to separate messages.
The functionality of `append_nul` that was a boolean variable stays the same since the user can override this value since it's a class attribute:
From the docs:
```
To enable easier handling of Syslog messages in the face of all these differing daemon behaviours, the appending of the NUL byte has been made configurable, through the use of a class-level attribute, append_nul. This defaults to True (preserving the existing behaviour) but can be set to False on a SysLogHandler instance in order for that instance to not append the NUL terminator.
```
So now this functionality is possible through setting:
```
message_separator_character = ''  # using the empty string
# instead of doing:
# append_nul = False
```

reahaas requested a review from vsajip as a code owner

February 17, 2021 15:26

the-knights-who-say-ni commented Feb 17, 2021

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@reahaas

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

the-knights-who-say-ni added the CLA not signed label

Feb 17, 2021

bedevere-bot added the awaiting review label

Feb 17, 2021


          Update handlers.py

f5ac76c

Better concatenating of the message_separator_character to the msg.

github-actions Bot commented Mar 20, 2021

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Mar 20, 2021

iritkatriel commented May 21, 2021

Copy link

Copy Markdown

Member

please create an issue on bpo and explain what problem you are trying to solve here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel requested changes

May 21, 2021

View reviewed changes

iritkatriel left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs an issue on bpo, unit tests and documentation change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting changes and removed awaiting review labels

May 21, 2021

bedevere-bot commented May 21, 2021

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk mentioned this pull request

Feb 17, 2022

Cron job to close stale PRs python/core-workflow#93

Closed

github-actions Bot removed the stale Stale PR or inactive for long period of time. label

Feb 19, 2022

github-actions Bot commented Mar 21, 2022

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Mar 21, 2022

github-actions Bot commented Apr 4, 2022

Copy link

Copy Markdown

Closing this stale PR because the CLA is still not signed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot closed this

Apr 4, 2022

Reviewers

iritkatriel

iritkatriel requested changes

vsajip

Awaiting requested review from vsajip

vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes stale

Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.