GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40522: Use PyThreadState_Get() in decimal by corona10 · Pull Request #24597 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 20, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40522

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-40522: Use PyThreadState_Get() in decimal
d92ea60
@corona10 corona10 added the skip news label Feb 20, 2021
@corona10
corona10 requested a review from vstinner February 20, 2021 06:24
@corona10
corona10 requested a review from rhettinger as a code owner February 20, 2021 06:24
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 20, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Feb 20, 2021
@vstinner

vstinner commented Feb 20, 2021

Copy link
Copy Markdown
Member

In commit 6207810, I wanted to clarify that the function is used in practice rather than the macro in public Python header files. But in _decimal, I suggest either to leave it unchanged, or switch to faster _PyThreadState_GET() which is always inlined.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Feb 20, 2021

Copy link
Copy Markdown
Member Author

@vstinner Got it, Okay let's leave it to be unchanged ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 closed this Feb 20, 2021
@corona10
corona10 deleted the bpo-40522-decimal branch February 20, 2021 13:03
@vstinner vstinner mentioned this pull request Apr 10, 2022
[subinterpreters] Get the current Python interpreter state from Thread Local Storage (autoTSSkey) #84702
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.